Bob Nystrom
Bob Nystrom
I ran the example through the [forthcoming](https://github.com/dart-lang/dart_style/issues/1403) [tall style](https://github.com/dart-lang/dart_style/issues/1253) and it produces: ```dart var s1 = [ 'a' 'b' + 'c', 'd' + 'e' 'f', ]; var s2 = [...
I think the [forthcoming](https://github.com/dart-lang/dart_style/issues/1403) [tall style](https://github.com/dart-lang/dart_style/issues/1253) handles this more or less how I expect, though it isn't exactly what's requested. When it can, it avoids splitting after `=>` at all....
Yeah, generated code tends to hit all of the worst-case performance corners of the formatter.
Hey, Daco. I believe the new formatter should have much better performance, but I'd like to write a regression test to verify that. It looks like the slow files have...
I dug into it and the piece of code that causes most of the formatter slowdown is: ```dart final passInt32x8Doublex8Int64Int8Struct1ByteIntInt64IntLeaf = ffiTestFunctions.lookupFunction< Double Function( Int32, Int32, Int32, Int32, Int32, Int32,...
Good catch. The formatter doesn't do any import reordering (because that can be surprisingly complex), but it could at least insert a newline between `dart:` and package imports.
Reordering code can get difficult when things like comments and commented out code is involved. To avoid potentially reordering things in ways that don't make sense, the formatter is currently...
Yeah, I think this is likely a different bug. I suspect that this has to do with a very obscure corner of the formatter that would be hard to describe....
I honestly don't know what the old formatter was doing, but the simpler argument list splitting style in the [forthcoming](https://github.com/dart-lang/dart_style/issues/1403) [tall style](https://github.com/dart-lang/dart_style/issues/1253) yields: ```dart @Deprecated( 'loooooooooooooooooooooooong text string' 'loooooooooooooooooooooooong text...
Oof, yeah. I spent a surprising amount of time working on the formatting for comments that appear in switch statements between cases but not between a case and its body....