Bob Nystrom
Bob Nystrom
Since the new formatter does a good job on this code and we're planning to move to that, I'm going to go ahead and close this.
The [forthcoming](https://github.com/dart-lang/dart_style/issues/1403) [tall style](https://github.com/dart-lang/dart_style/issues/1253) formatter doesn't have this bug and produces: ```dart await _loadProfileView( userId: profileView.userId, setLikeActionType: LikeActionType.block, // Remove star too from any user that is blocked setStarAction: false,...
Ugh, I'm going to spend the rest of my life dealing with corner cases in the interactions between trailing commas and the rest of the language. :(
> FWIW I think this is fixed with the new tall style. Once we're a little closer to shipping, I plan to go through the issue tracker and close out...
As @srawlins notes, this is looking good in the [forthcoming](https://github.com/dart-lang/dart_style/issues/1403) [tall style](https://github.com/dart-lang/dart_style/issues/1253).
Ah, wait. Don't review this yet. I just realized that I can repro this if the line separator is at the *end* of a line.
Right. The [forthcoming](https://github.com/dart-lang/dart_style/issues/1403) [tall style](https://github.com/dart-lang/dart_style/issues/1253) gives you: ```dart it( 'should complete with an error if the name or website is null or both ' 'are unchanged', async(() { ICouldDoAnything(); }),...
I'm going to close this in favor of #1465 which is newer, but has more context about why the new formatter doesn't support it yet.
> we are finding deeply nested code, which leads to lots of space being wasted as pure indentation. Increasing the column limit doesn't really fix that problem. You're still wasting...
> The problem is when we are obligated to run dartfmt before each commit. You can pass `--line-length=` to dartfmt to specify a custom column limit for whatever value you...