mun icon indicating copy to clipboard operation
mun copied to clipboard

Remove instances of `#[allow(clippy::mutable_key_type)]`

Open Wodann opened this issue 1 year ago • 1 comments

Some of the Mun code is violating the clippy::mutable_key_type lint, but cannot be trivially fixed. Refactor the code to prevent this and remove all instances of #[allow(clippy::mutable_key_type)].

Wodann avatar Sep 30 '24 05:09 Wodann

I say that this is a case of the lint's false positives given that the Hash implementation for Type does not rely on any interior-mutable fields.

(However, changing the keys to perhaps use TypeDataKind directly would probably perform slightly better as the Arc to the data store would not be unnecessarily cloned.)

wackbyte avatar Oct 02 '24 01:10 wackbyte