aws-secret-operator icon indicating copy to clipboard operation
aws-secret-operator copied to clipboard

Secrets has the AwsVersionId Key by default

Open james-nduka opened this issue 4 years ago • 2 comments

Can we avoid each secret being created to include the key for AWSVersionID?

We have a CRD that can only accept a single Key/Value and it is currently not compatible with AWSSecret CRD's

james-nduka avatar Jan 25 '21 12:01 james-nduka

@james-nduka Hey! It's not supported, but technically possible. Today, we only use AWSVersionID for change detection:

https://github.com/mumoshu/aws-secret-operator/search?q=AWSVersionID

We may instead use another store, like some annotation on the secret resource for the same purpose, which would help your use-case.

Probably it should be configurable via some AwsSecret field?

mumoshu avatar Jan 25 '21 23:01 mumoshu

I agree that if it's only for change detection purpose, using an annotation makes more sense than including the version ID as part of the AWSSecret CRD itself.

ChangSurrey avatar May 11 '21 10:05 ChangSurrey