mumble
mumble copied to clipboard
RPC allows to set arbitrary values
Describe the bug gRPC allows to set arbitrary values and arbitrary fields.
Steps to Reproduce
$ ./murmur-cli config set-field 2 allowhtml "I like beer"
{}
./murmur-cli config get 2
{"server":{"id":2},"fields":{"allowhtml":"I like beer"}}
$ ./murmur-cli config set-field 2 UsEleSsFiElD "I drink beer"
{}
$ ./murmur-cli config get 2
{"server":{"id":2},"fields":{"UsEleSsFiElD":"I drink beer","allowhtml":"I like beer"}}
Expected behavior murmurd should return an error and shouldn't write bogus values.
Do you happen to know whether ICE does check its parameters (aka: is this specific to gRPC or is this a problem with our RPC interface in general?)
I've never tried ICE and I have also no idea how gRPC and the RPC in general works.
Okay - I've been told that this does indeed apply to ICE as well.
reimplement RPC in Grumble ;)