mumble icon indicating copy to clipboard operation
mumble copied to clipboard

RPC allows to set arbitrary values

Open streaps opened this issue 4 years ago • 4 comments

Describe the bug gRPC allows to set arbitrary values and arbitrary fields.

Steps to Reproduce

$ ./murmur-cli config set-field 2 allowhtml "I like beer"
{}
./murmur-cli config get 2
{"server":{"id":2},"fields":{"allowhtml":"I like beer"}}
$ ./murmur-cli config set-field 2 UsEleSsFiElD "I drink beer"
{}
$ ./murmur-cli config get 2
{"server":{"id":2},"fields":{"UsEleSsFiElD":"I drink beer","allowhtml":"I like beer"}}

Expected behavior murmurd should return an error and shouldn't write bogus values.

streaps avatar Jun 03 '20 14:06 streaps

Do you happen to know whether ICE does check its parameters (aka: is this specific to gRPC or is this a problem with our RPC interface in general?)

Krzmbrzl avatar Jun 03 '20 16:06 Krzmbrzl

I've never tried ICE and I have also no idea how gRPC and the RPC in general works.

streaps avatar Jun 03 '20 17:06 streaps

Okay - I've been told that this does indeed apply to ICE as well.

Krzmbrzl avatar Jun 03 '20 18:06 Krzmbrzl

reimplement RPC in Grumble ;)

streaps avatar Jun 03 '20 19:06 streaps