termdash icon indicating copy to clipboard operation
termdash copied to clipboard

Added Tab widget, demo, and tests

Open keithknott26 opened this issue 1 year ago • 5 comments

Hello Jakub,

I've added Tab support via the Tab widget. It includes a demo of the features including FollowNotifications which switches the active tab automatically whenever there's a notification alarm. I've also added tests and comments.

I'll try to update the README in main in the next few days.

Thanks, Keith Knott

keithknott26 avatar Sep 18 '24 18:09 keithknott26

Screenshot 2024-09-18 at 8 13 18 PM

keithknott26 avatar Sep 19 '24 00:09 keithknott26

Another really cool widget, thank you Keith. I'll get to the review shortly and then we can release both of these (tab and treeview) together.

mum4k avatar Sep 21 '24 15:09 mum4k

Before we get into the review here, could you address the failing checks? Looks like the CI identified a few lint errors.

If you can, please also update the README.md with a screenshot or a gif showing off the widget.

mum4k avatar Sep 25 '24 18:09 mum4k

Jakub,

You're very welcome i'm happy to contribute I really like your work. I've resolved the linting errors and optimized the code a bit, also added an animated gif and updated the README. If the gifs don't really match perhaps you can try with your normal terminal for treeview and tab I like the orange you have in the other gifs. For the animated gif capture I use liceCAP.

Let me know if you'd like me to make any changes.

Btw - I saw some really interesting 3d engine for the terminal on github like this one: https://github.com/kohkubo/term3d and i'm wondering if I can't integrate it somehow into your project. I'm not sure what to use it for yet but it would involve converting the algorithms over to Go code and then having it read from an obj file... have a look and see if you can spot anything that might be helpful in your project... i'm happy to have a go at it but as I said I'm just not sure how it could be useful for this project, cool nonetheless ;)

Cheers, Keith Knott

keithknott26 avatar Sep 29 '24 08:09 keithknott26

Wen't through the rest of the code, have no major comments. Thank you for the contribution @keithknott26 !

mum4k avatar Oct 06 '24 14:10 mum4k