Dataverse icon indicating copy to clipboard operation
Dataverse copied to clipboard

Fixing the send button issue in the form #67

Open tarunkumar2005 opened this issue 1 year ago • 5 comments

Description

I have fixed the form layout and send button and it is looking more good now as you can see in the image :-

image

Related Issue

Fixes #67

Type of change

  • [X] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • [X] My code follows the style guidelines of this project
  • [X] I have performed a self-review of my own code
  • [X] I have commented on my code, particularly in hard-to-understand areas
  • [X] I have added tests that prove my fix is effective or that my feature works
  • [X] New and existing unit tests pass locally with my changes
  • [X] Any dependent changes have been merged and published in downstream modules

tarunkumar2005 avatar Oct 07 '24 11:10 tarunkumar2005

Deploy Preview for multiverse-dataverse ready!

Name Link
Latest commit 3cefa7bb6633a5bb55b1806eb7e78161fa8b8f80
Latest deploy log https://app.netlify.com/sites/multiverse-dataverse/deploys/670b5039eb500e0008c346b0
Deploy Preview https://deploy-preview-75--multiverse-dataverse.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 07 '24 11:10 netlify[bot]

@multiverseweb Can you review and merge it soon its been so many days since it is open

tarunkumar2005 avatar Oct 11 '24 05:10 tarunkumar2005

@jency1 Can you review this PR and ask the admin to merge it

tarunkumar2005 avatar Oct 12 '24 10:10 tarunkumar2005

@multiverseweb Now check there was issue in the style.css file there one person didn't comented the word responsive properly and that was breaking the code and so the responsiveness was not there, it is fixed now you can check.

tarunkumar2005 avatar Oct 13 '24 04:10 tarunkumar2005

@multiverseweb Can you check the PR now i have fixed the issues now.

tarunkumar2005 avatar Oct 14 '24 06:10 tarunkumar2005

@multiverseweb @jency1 Can you check the PR and merge it its been open for too long (reminder)

tarunkumar2005 avatar Oct 16 '24 10:10 tarunkumar2005

@multiverseweb Review this PR if it has done the requested changes and @tarunkumar2005 resolve the conflicts

MastanSayyad avatar Oct 18 '24 14:10 MastanSayyad

Hey @tarunkumar2005, sorry for delay in code review, was totally packed up. This is how the current form looks in mobile view: image

And this is the form in your PR: image

Here are the issues with this PR:

  • The font-style of the place holder in message field is different as compare to the other two fields.
  • The font color of Let Me Know Your Thoughts has been changed, which makes it disappear in light mode.
  • The margin between fields has been increased, which makes the form look vertically elongated.

The issue #67 only required aligning the send button, which certainly has been solved in you PR, but newer issues have been introduced. The button alignment has already been fixed in some PR, as you can see here. Therefore, I'm closing the issue. Let me know if you have further doubts.

multiverseweb avatar Oct 18 '24 22:10 multiverseweb