Add images to button issue #51

[Rohan20-10]

trafficstars

Description

Please include a summary of the changes and the related issue. Also, explain the motivation behind this PR.

Related Issue

Fixes # (issue)

Type of change

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented on my code, particularly in hard-to-understand areas
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes
• [x] Any dependent changes have been merged and published in downstream modules

@multiverseweb I have added the images for the buttons up to radar chart. The remaining images are not available easily and do not characterize the particular plot clearly so if any changes required for those do let me know. Attaching the screenshot of what I have attempted. Please review the pr.

[netlify[bot]]

✅ Deploy Preview for multiverse-dataverse ready!

Name	Link
🔨 Latest commit	74070a59c330705d7057373e7d255fc035e7ee72
🔍 Latest deploy log	https://app.netlify.com/sites/multiverse-dataverse/deploys/67162456dbc6e80009a5fb64
😎 Deploy Preview	https://deploy-preview-125--multiverse-dataverse.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Rohan20-10]

@multiverseweb I can align that images to the left of the button. The second point you mentioned about the transparent images is being implemented but the thing is that if I do the other way which you are suggesting then the problem is that when we hover over that button then that image hides. So I did this way. Pls, let me know your feedback about it. To help you understand what I am saying, I've attached the video for the line graph image, which shows the changes you suggested. Screen-Recording.webm

[Rohan20-10]

@multiverseweb any updates ?

[multiverseweb]

@multiverseweb I can align that images to the left of the button. The second point you mentioned about the transparent images is being implemented but the thing is that if I do the other way which you are suggesting then the problem is that when we hover over that button then that image hides. So I did this way. Pls, let me know your feedback about it. To help you understand what I am saying, I've attached the video for the line graph image, which shows the changes you suggested. Screen-Recording.webm

@Rohan20-10 sorry for the delay in reviewing the code, was overloaded with tasks. Somehow this effect on hover does not appear on my computer. The better solution is to keep the images transparent, and we will create a new issue for changing the button color on hover. This will keep the images visible on hover too,. What do you think?

[Rohan20-10]

Hey @Rohan20-10, kindly make the required changes and send the PR. Waiting to hear your opinion.

@multiverseweb Yeah, Sure. I will do what you suggested and then create a separate issue for the change in the visibility of images on hover. Thanks.

[Rohan20-10]

@multiverseweb I have made the changes that you suggested. Please review the pr. Thanks.

[multiverseweb]

Looks great, merging.

[multiverseweb]

@Rohan20-10 checkout the latest version of the software, I've added images to all the buttons and fixed their dimensions

[Rohan20-10]

@Rohan20-10 checkout the latest version of the software, I've added images to all the buttons and fixed their dimensions

It is looking fabulous. Great work @multiverseweb. Thanks.