dc-woocommerce-multi-vendor
dc-woocommerce-multi-vendor copied to clipboard
Grunt default process fails on master
On a fresh clone and install of this project, the grunt process fails in multiple tasks in multiple file locations. Using node version v12.13.0 -- I'll try to outline each error encountered.
1. Invalid scss / css here: https://github.com/wcmarketplace/dc-woocommerce-multi-vendor/blob/master/assets/frontend/css/advance-product-manager.scss#L387 (css task)
$ grunt
Running "uglify:admin" (uglify) task
>> 14 files created 131.87 kB → 66.67 kB
Running "uglify:frontend" (uglify) task
>> 19 files created 231.71 kB → 105.97 kB
Running "sass:compile" (sass) task
>> Error: Invalid CSS after " }": expected selector or at-rule, was "}"
>> on line 392 of assets/frontend/css/advance-product-manager.scss
>> >> }
>>
>> ----^
Warning: Use --force to continue.
Aborted due to warnings.
2. Invalid scss / css here: https://github.com/wcmarketplace/dc-woocommerce-multi-vendor/blob/master/assets/frontend/css/vendor-registration.scss#L215 (css task)
$ grunt
Running "uglify:admin" (uglify) task
>> 14 files created 131.87 kB → 66.67 kB
Running "uglify:frontend" (uglify) task
>> 19 files created 231.71 kB → 105.97 kB
Running "sass:compile" (sass) task
>> Error: property "url-prefix" must be followed by a ':'
>> on line 214 of assets/frontend/css/vendor-registration.scss
>> >> url-prefix() {
>>
>> -^
Warning: Use --force to continue.
Aborted due to warnings.
3. Invalid scss / css here: https://github.com/wcmarketplace/dc-woocommerce-multi-vendor/blob/master/assets/frontend/css/vendor_dashboard.scss#L1724 (css task)
$ grunt
Running "uglify:admin" (uglify) task
>> 14 files created 131.87 kB → 66.67 kB
Running "uglify:frontend" (uglify) task
>> 19 files created 231.71 kB → 105.97 kB
Running "sass:compile" (sass) task
>> Error: property "url-prefix" must be followed by a ':'
>> on line 1724 of assets/frontend/css/vendor_dashboard.scss
>> >> url-prefix() {
>>
>> -^
Warning: Use --force to continue.
Aborted due to warnings.
4. Once all of the above are resolved, the RTL process fails (rtlss task):
$ grunt
Running "uglify:admin" (uglify) task
>> 14 files created 131.87 kB → 66.67 kB
Running "uglify:frontend" (uglify) task
>> 19 files created 231.71 kB → 105.97 kB
Running "sass:compile" (sass) task
Running "cssmin:target" (cssmin) task
>> Skipping remote @import of "https://fonts.googleapis.com/css?family=Open+Sans:400,600" as no callback given.
>> 9 files created. 320.27 kB → 254.75 kB
Running "postcss:dist" (postcss) task
>> 36 processed stylesheets created.
Running "rtlcss:admin" (rtlcss) task
Fatal error: Could not convert: assets/admin/css/admin-rtl.css due to: CssSyntaxError: /Users/jonsakas/Development/dc-woocommerce-multi-vendor/assets/admin/css/admin.min.css:1958:21: Unknown word
5. After removing RTL process, grunt i18n task fails (i18n task)
$ grunt
Running "uglify:admin" (uglify) task
>> 14 files created 131.87 kB → 66.67 kB
Running "uglify:frontend" (uglify) task
>> 19 files created 231.71 kB → 105.97 kB
Running "sass:compile" (sass) task
Running "cssmin:target" (cssmin) task
>> Skipping remote @import of "https://fonts.googleapis.com/css?family=Open+Sans:400,600" as no callback given.
>> 9 files created. 320.27 kB → 254.75 kB
Running "postcss:dist" (postcss) task
>> 36 processed stylesheets created.
Running "checktextdomain:files" (checktextdomain) task
admin/class-wcmp-admin-setup-wizard.php
[L196] __ Incorrect text domain used ("primary")
... REMOVED ...
templates/vendor-dashboard/vendor-shipping/vendor-shipping-zone-settings.php
[L75] _e Incorrect text domain used ("wcmp")
Warning: 420 problems Use --force to continue.
Aborted due to warnings.
@itzmekhokan can you provide some insight here? How is the WCMp team able to build the project when everything in the repo fails to build on the master branch.
Are there some development environment set up steps that we are missing? Perhaps the README should be used to describe developing the project instead of the strange sales dialog that exists today.
How is the WCMp team building this project? Can we get some development instructions please.