dc-woocommerce-multi-vendor icon indicating copy to clipboard operation
dc-woocommerce-multi-vendor copied to clipboard

WCMp_WP_Fields and WCMp_Frontend_WP_Fields issues.

Open luiseduardobraschi opened this issue 6 years ago • 1 comments

Hi. WCMp_WP_Fields and WCMp_Frontend_WP_Fields have very similar structures and could be merged into one and/or inherited. There are a few issues in them too.

custom_attributes handling will add "data-*" to the attributes, so you can't use plenty of available attributes you would like to such as autocomplete or pattern.

Some text type inputs are missing. For example, I had to use the classes themselves instead of adding a new field to the fields array in the filter wcmp_vendor_user_fields because type => 'password' yields nothing.

There are typos and commented code all over.

If you agree with any of the above, I can send some PRs on the next weeks.

Now a suggestion based in a personal opinion; some methods have prefixes. I think they should be deprecated in favour of non-prefixed ones.

Best regards.

luiseduardobraschi avatar May 27 '18 14:05 luiseduardobraschi

Hi Luis, We have added this to our future milestone with "normal" priority. Will keep you posted.

sushobhan-pal avatar May 30 '18 06:05 sushobhan-pal