mtasa-resources icon indicating copy to clipboard operation
mtasa-resources copied to clipboard

editor: fixes, random rotation func, getCurrentMapName func, updated scale func

Open PrimelPrime opened this issue 7 months ago • 4 comments

This PR fixes #589, #603 and also some other smaller issues, like unnecessary outputDebugMessages. There was also a weird camera bug that only happened whenver you created a ped and or marker which was caused due of how the elementcreation got handled -> see elementcreation.lua

I've also revamped the scale functionality I implemented with #604 which mainly removes needless special handling for scale and also now only returns one value when getObjectScale() is called. Further I moved the settings into an advanced tab, as it would have gotten to cluttered with new functionality of the rotation stuff and looks cleaner in general. To add to that there where also some issues with outside resources, mainly mtp by @chris1384 where the scale property would not update correctly.

The settings.xml now also gets read properly and adds any values it might be missing. Before this change you wouldn't be able to use the editor anymore if any value/setting was missing.

There was also an incorrect implementation of the doubleside property, everytime you copied and object it would set it to true by default even though it should be false. I'm probably missing some smaller stuff that got changed in the process.

See video below. Sorry for the sound quality: https://www.youtube.com/watch?v=BQghNXO8H4g

Edit: One more thing I wanted to mention, we always pass creation parameters for rotation from the client to the server now this might or might not fix one of the weird rotation bugs that can happen https://www.youtube.com/watch?v=UXMcEXorgiM

PrimelPrime avatar May 10 '25 01:05 PrimelPrime

Thank you for the video that summarizes everything! I'll take a look at the code

Fernando-A-Rocha avatar May 10 '25 01:05 Fernando-A-Rocha

Reverted one change I got made aware of by @q8X , thanks

PrimelPrime avatar May 10 '25 01:05 PrimelPrime

https://www.youtube.com/watch?v=mdx0p5esJYo

PrimelPrime avatar May 12 '25 08:05 PrimelPrime

most recent change avoids this bug in the editor: https://www.youtube.com/watch?v=XY41oYG2O3I

PrimelPrime avatar May 17 '25 04:05 PrimelPrime