mtasa-blue icon indicating copy to clipboard operation
mtasa-blue copied to clipboard

Add bone quaternion functions

Open gownosatana opened this issue 1 year ago • 1 comments

This pull request adds quaternion functions for bones which gives more control of bones

Test resource: test.zip

gownosatana avatar Aug 25 '24 16:08 gownosatana

Sorry, forgot to change in header files, now should be good to go

gownosatana avatar Aug 26 '24 14:08 gownosatana

@tederis

gownosatana avatar Aug 28 '24 20:08 gownosatana

I would rename these functions to setElementBoneQuaternion and getElementBoneQuaternion. Because setElementBoneRotationQuaternion is oxymoron as quaternion means rotation as well.

tederis avatar Aug 29 '24 04:08 tederis

I would rename these functions to setElementBoneQuaternion and getElementBoneQuaternion. Because setElementBoneRotationQuaternion is oxymoron as quaternion means rotation as well.

renamed

gownosatana avatar Aug 29 '24 11:08 gownosatana

Although some of the conversations was marked as resolved without being actually finished I tend to turn a blind eye on it. Non-critical discrepancies in code style should not prevent a good PR from being merged in my opinion.

tederis avatar Sep 10 '24 15:09 tederis

Please document the new functions on wiki, @gownosatana

To be added: https://wiki.multitheftauto.com/wiki/SetElementBoneQuaternion https://wiki.multitheftauto.com/wiki/GetElementBoneQuaternion

// Edit: done, but despite the author's failure to do it, someone else did. For future reference: https://i.imgur.com/Iboa44o.png (it will be a pre-requirement of their next PR's).

Dutchman101 avatar Sep 12 '24 06:09 Dutchman101