mtasa-blue icon indicating copy to clipboard operation
mtasa-blue copied to clipboard

Fix HUD size when playing on widescreen

Open henrymarques opened this issue 1 year ago • 9 comments

Fix #848, maybe fix #2753 There's nothing new, most part of the code is from ThirteenAG's widescreen fix (thanks).

This is a draft pull request because it needs more testing. If you can test it, please, send me feedback. I need feedback about the code too.

henrymarques avatar Jun 08 '24 21:06 henrymarques

I've read all the reviews, I will reply and work on the changes when I have a break

henrymarques avatar Jun 13 '24 04:06 henrymarques

thank you for your work, i hope this is finished :D

hud looks like this without your PR, stretched and too big 😔 image

Fernando-A-Rocha avatar Jun 18 '24 12:06 Fernando-A-Rocha

vs on samp with widescreen hud fix

image

Fernando-A-Rocha avatar Jun 18 '24 12:06 Fernando-A-Rocha

Thanks for working on this!

Just curious if this fix also covers FoV issues (reported in #2753) or if the fix would be a totally separate thing?

DomenicF avatar Jul 09 '24 13:07 DomenicF

Just curious if this fix also covers FoV issues [...] or if the fix would be a totally separate thing?

Not yet, it's not totally separate thing but I think I will open another pull request to this

henrymarques avatar Jul 13 '24 23:07 henrymarques

Everything seems to work correctly, but I would like if another dev could test this

henrymarques avatar Jul 13 '24 23:07 henrymarques

At this point, HUD size can be changed back switching aspect ratio to 4:3 on video settings, I don't know if this setting change could have side effects elsewhere than HUD. If this happen, please tell me, so I will think how to solve with "HUD match aspect ratio" setting checkbox. I will work on fov fix now

EDIT:

[...] I don't know if this setting change could have side effects elsewhere than HUD.

It has, but I found a way to solve using "HUD match aspect ratio" checkbox. I don't think it's the better way but it works, also, unfortunetly the game needs to restart to apply changes. I can commit it as is to this PR if someone thinks it is needed

henrymarques avatar Jul 18 '24 23:07 henrymarques

Related to #3582 ?

Fernando-A-Rocha avatar Jul 25 '24 10:07 Fernando-A-Rocha

Related to #3582 ?

You can see the changes here, I don't think it's the better way to do this, so I didn't include in this PR

henrymarques avatar Jul 25 '24 18:07 henrymarques

Any updates on this? This is a long awaited feature, actually the issue is in the 1.6.1 milestone

Nico8345 avatar Jan 04 '25 16:01 Nico8345

It would be very interesting if this pull returned

YSAFE avatar Jan 04 '25 16:01 YSAFE

I personally like the current "big" hud for 1080p (bad eyes) but I understand that it gets too big on 4k screens. An option where you could scale the hud is impossible?

ghost avatar Jan 04 '25 18:01 ghost

Hello! I was very sick last 4 months but I can continue this pr now, I do not remember what I was doing but I got issues with memory addresses as FileEX mentioned, maybe we could separate this into 2 pr since hud changes is ready (at least was before FileEX hud customizations but it seems easy to make it work again)

henrymarques avatar Jan 04 '25 18:01 henrymarques

I personally like the current "big" hud for 1080p (bad eyes) but I understand that it gets too big on 4k screens. An option where you could scale the hud is impossible?

HUD match aspect ratio option will be kept, so you can use the big HUD simply unchecking that option, isn't the best solution but implementing HUD scale without making things weird needs more thinking

henrymarques avatar Jan 09 '25 06:01 henrymarques

Nice! Will you add a client setting to keep the old hud? It should be disabled by default because your fixed version is nicer, imo

Fernando-A-Rocha avatar Jan 11 '25 23:01 Fernando-A-Rocha

Nice! Will you add a client setting to keep the old hud? It should be disabled by default because your fixed version is nicer, imo

Yes, just uncheck "HUD match aspect ratio" checkbox on video options, it's checked by default (which means that will be using fixed hud)

henrymarques avatar Jan 12 '25 17:01 henrymarques