mtasa-blue icon indicating copy to clipboard operation
mtasa-blue copied to clipboard
verified publisher icon multitheftauto

onPlayerTeamChange Event

Open esmail9900 opened this issue 1 year ago • 4 comments

implemented the onPlayerTeamChange event for the server-side. this event includes two arguments: oldTeam and newTeam. if the player doesn't have an old team, oldTeam will be false.

esmail9900 avatar Apr 21 '24 10:04 esmail9900

How about enabling cancelEvent() for this new event?

tederis avatar Apr 21 '24 11:04 tederis

Hello @esmail9900 and thank you for your PR.

Your PR gave me some strong flashbacks from when I attempted to add this event and lost motivation.

Please view the comments on this PR https://github.com/multitheftauto/mtasa-blue/pull/10 and check if your code complies with all that have been said in this PR.

Thank you.

Citizen01 avatar Apr 21 '24 14:04 Citizen01

You forgot some of my suggestions.

If they have been left on purpose, please explain why.

esmail9900 avatar Apr 23 '24 23:04 esmail9900

You forgot some of my suggestions.

If they have been left on purpose, please explain why.

mb, i just confused, im new to github :D

esmail9900 avatar Apr 23 '24 23:04 esmail9900

There are enough passed code reviews, thanks for your contribution @esmail9900

Dutchman101 avatar May 23 '24 23:05 Dutchman101