mtasa-blue icon indicating copy to clipboard operation
mtasa-blue copied to clipboard

Add extendedwatercannons special world property

Open FileEX opened this issue 10 months ago • 7 comments

Added extendedwatercannons special world property, that allows the maximum number of water cannons to be extended at the same time. I set the new limit to 30 because that number seems to be enough, perhaps even too much.

image

Thanks to @Merlin for help with crashes

Resolved #3315

FileEX avatar Apr 15 '24 23:04 FileEX

Would there be any disadvantage to just increasing this limit by default? I don't think this is a case where the limited default behavior is desirable at all, therefore being able to toggle between the two seems rather unnecessary to me.

Dark-Dragon avatar Apr 16 '24 00:04 Dark-Dragon

Would there be any disadvantage to just increasing this limit by default? I don't think this is a case where the limited default behavior is desirable at all, therefore being able to toggle between the two seems rather unnecessary to me.

The same can be said about vegetation (randomfoliage) and underwater creatures - toggle them seems unnecessary, but you can toggle them anyway. I believe we can set this property to enabled by default, but I still think leaving the option to disable it isn't a bad thing. It is better when the user has choice and freedom than predefined settings that he cannot change.

In addition, it seems to me that few people really need an increased limit. In 12 years of playing, I never even noticed that such a limit even existed, and no one had ever reported it before.

FileEX avatar Apr 16 '24 09:04 FileEX

Well there could be had a conversation about what the reasons might be it wasn't reported in the first place, but having it on by default seems like a fine compromise. Still I wouldn't be surprised if it will take more than 12 years for someone to specifically need to disable it, whereas I can see scenarios where foliage and water creatures could be desired or undesired. I'm just thinking the special world properties are slowly starting to get rather crowded, but that's not for me to decide, so I just want to point it out whenever I can.

Dark-Dragon avatar Apr 16 '24 12:04 Dark-Dragon

I think it's good that we get new world properties. Thanks to this, server creators on MTA have more and more freedom and more opportunities. If someone doesn't want foliages, they can disable it, if someone doesn't want flipped cars to burn, they can disable this property. The same in this case, if for some reason someone really does not need such a limit extension, then disable this property. I think it's better to have this option than not to have it.

FileEX avatar Apr 16 '24 12:04 FileEX

Please fix conflicts and we can merge this

Lpsd avatar May 23 '24 17:05 Lpsd

Please fix conflicts and we can merge this

Done

FileEX avatar May 23 '24 18:05 FileEX

I think this limit should be increased by default.

lopezloo avatar May 27 '24 21:05 lopezloo

I think this limit should be increased by default.

As you can see https://github.com/multitheftauto/mtasa-blue/pull/3365/commits/bff7007fe674e6c75f129f1ac68b39ed9a2a2d05

The limit is increased by default

FileEX avatar May 28 '24 19:05 FileEX