mtasa-blue icon indicating copy to clipboard operation
mtasa-blue copied to clipboard
verified publisher icon multitheftauto

Fix #2965: sourceResourceRoot is incorrect in event handlers

Open TracerDS opened this issue 2 years ago • 7 comments

Currently MTA is pushing dynamic resource root element instead of normal resource root element. Changing it from GetResourceDynamicEntity to GetResourceEntity fixes the issue

TracerDS avatar May 22 '23 18:05 TracerDS

i see one problem with this fix: people may already depend on this bug in their existing resources so now you are breaking them

CrosRoad95 avatar May 22 '23 18:05 CrosRoad95

i see one problem with this fix: people may already depend on this bug in their existing resources so now you are breaking them

maybe its time to stop relying on bugs ¯\(ツ)/¯

TracerDS avatar May 22 '23 19:05 TracerDS

I guess you can still do that, and it can be pushed to 1.6 branch - because this version already breaks some stuff, see: https://wiki.multitheftauto.com/wiki/Changes_in_1.6 obraz

sacr1ficez avatar May 22 '23 22:05 sacr1ficez

I think it's too late to push this with 1.6, maybe next time.

botder avatar Jul 26 '23 09:07 botder

1.6.1 ?

Fernando-A-Rocha avatar May 05 '24 12:05 Fernando-A-Rocha

1.6.1 ?

It was actually ready for 1.6 but this PR didnt get enough attention 😢

TracerDS avatar May 05 '24 12:05 TracerDS

1.6.1 ?

It was actually ready for 1.6 but this PR didnt get enough attention 😢

It's never too late!

Fernando-A-Rocha avatar May 05 '24 14:05 Fernando-A-Rocha