multitheftauto
Allow multiple ignored elements to be passed to processLineOfSight
This allows multiple ignore elements to be passed to processLineOfSight, via table of elements.
It is backwards compatible. If you pass a single element, or nil as ignoredElements it has the same behaviour as before.
processLineOfSight ( float startX, float startY, float startZ,
float endX, float endY, float endZ,
[ bool checkBuildings = true,
bool checkVehicles = true,
bool checkPlayers = true,
bool checkObjects = true,
bool checkDummies = true,
bool seeThroughStuff = false,
bool ignoreSomeObjectsForCamera = false,
bool shootThroughStuff = false,
table ignoredElements = nil,
bool includeWorldModelInformation = false,
bool bIncludeCarTyres ] )
Partially [resolves] #1549
I will submit a separate PR for isLineOfSightClear
Wouldn't it be better to take a table of elements?
elements = {}
processLineOfSight(...,unpack(elements),...) -- can't do this
I suppose you could the put last arguments as the last values in the table.
I'll add the ability to pass a table, as well as vararg.
Having it at the end would be weird, because we have to keep the original argument order to some extent.
Time to merge this. @Lpsd address the comments, and I'll merge it. I hope you've tested it (But there's really nothing not to work, so)
Vararg removed.
Test resource: los.zip
Spawns 50 bin objects in a row. Use command /los <amountToIgnore>
e.g /los 50 should return nil for processLineOfSight in debug output, as you're ignoring all elements
/los 30 will output bin_31, as that's the next object to hit after 30
/los 0 will output bin_1
etc
This resource also tests backwards compatibility by passing nil as ignoredElements if 0 is supplied to the command. It shouldn't raise a warning / error (just like original behaviour).
Is there anything left to do here or why is it not merged?
Nothing left to do here, not merged yet because feature freeze is on (https://discord.com/channels/801330706252038164/801330706252038167/1059094962853130250). Will be merged for 1.6.
