mtasa-blue icon indicating copy to clipboard operation
mtasa-blue copied to clipboard

Use new arg parser for element data functions

Open Pirulax opened this issue 4 years ago • 10 comments

Requires #1450 and #1419

Pirulax avatar May 20 '20 03:05 Pirulax

Yeah, i failed miserably with merging the other PR, and accidentally leaving it in there.

Im ashamed of my stupidity.

Pirulax avatar May 20 '20 04:05 Pirulax

argument parser warn is only for pre 1.5.8 functions. so hasElementData + the fancy new element data functions should use a regular argument parser ArgumentParser<F>

qaisjp avatar May 20 '20 10:05 qaisjp

Do changes to the macro in shared element defs as suggested Actually, I've deleted it, and replaced it with a function.

Pirulax avatar May 20 '20 21:05 Pirulax

Well, rebasing was totally unnecessary... I could've cherry picked... Well, nvm now I guess.

Pirulax avatar May 25 '20 03:05 Pirulax

Turns out my super rebase didnt even include the PR merge of adding CLuaArgument to the parser...

Pirulax avatar May 25 '20 04:05 Pirulax

Yeah, i should rebase and remove these idiotic sommits, you're right.

Pirulax avatar May 25 '20 04:05 Pirulax

lets just get this working, and i dont care, we'll forget what happened here....

Pirulax avatar May 25 '20 04:05 Pirulax

Alright. Im not quite sure if its my fault, or the parser is being weird? Because it compiles just fine on Windows...

Pirulax avatar May 25 '20 05:05 Pirulax

Linux server doesn't compile

I think since CI has passed, that CR has been resolved?

buepas avatar Jun 08 '20 21:06 buepas

Thanks for fixing up the PR @qaisjp

Pirulax avatar Jun 09 '20 21:06 Pirulax

Merge conflicts must be resolved.

patrikjuvonen avatar Apr 08 '23 10:04 patrikjuvonen

This draft pull request is stale because it has been open for at least 90 days with no activity. Please continue on your draft pull request or it will be closed in 30 days automatically.

github-actions[bot] avatar Jul 08 '23 01:07 github-actions[bot]

This draft pull request was closed because it has been marked stale for 30 days with no activity.

github-actions[bot] avatar Aug 08 '23 01:08 github-actions[bot]