mtasa-blue
mtasa-blue copied to clipboard
Use new arg parser for element data functions
Requires #1450 and #1419
Yeah, i failed miserably with merging the other PR, and accidentally leaving it in there.
Im ashamed of my stupidity.
argument parser warn is only for pre 1.5.8 functions. so hasElementData + the fancy new element data functions should use a regular argument parser ArgumentParser<F>
Do changes to the macro in shared element defs as suggested Actually, I've deleted it, and replaced it with a function.
Well, rebasing was totally unnecessary... I could've cherry picked... Well, nvm now I guess.
Turns out my super rebase didnt even include the PR merge of adding CLuaArgument to the parser...
Yeah, i should rebase and remove these idiotic sommits, you're right.
lets just get this working, and i dont care, we'll forget what happened here....
Alright. Im not quite sure if its my fault, or the parser is being weird? Because it compiles just fine on Windows...
Linux server doesn't compile
I think since CI has passed, that CR has been resolved?
Thanks for fixing up the PR @qaisjp
Merge conflicts must be resolved.
This draft pull request is stale because it has been open for at least 90 days with no activity. Please continue on your draft pull request or it will be closed in 30 days automatically.
This draft pull request was closed because it has been marked stale for 30 days with no activity.