mtasa-blue icon indicating copy to clipboard operation
mtasa-blue copied to clipboard

Using banIP or banSerial as a variable will give you a warning

Open PlatinMTA opened this issue 4 years ago • 2 comments

Describe the bug You can't call a variable banIP or banSerial without getting an output on the server console/log.

To reproduce

-- serverside
banIP = "192.168.1.69"

Run that code and you will see and output similar to this:

[Server] banIP no longer works. Please manually update this. Refer to the wiki for details

Expected behaviour It should only tell you that if you are trying to use the function banIP

Version Server: r20488

Additional context This isn't that important, but w/e

PlatinMTA avatar May 11 '20 18:05 PlatinMTA

the outdated function checker is very bad, at best. It also flags other old function names, if it finds them in the code, probably using an strcmp, or something.

Pirulax avatar May 28 '20 20:05 Pirulax

https://github.com/multitheftauto/mtasa-blue/blob/master/Server/mods/deathmatch/logic/CResourceChecker.cpp#L721 https://github.com/multitheftauto/mtasa-blue/blob/3ac6dc926dbec43111f3968ba208720e5a988fd7/Server/mods/deathmatch/logic/CResourceChecker.cpp#L702

what should be done about this checker?

Fernando-A-Rocha avatar Jun 14 '22 21:06 Fernando-A-Rocha