dsq icon indicating copy to clipboard operation
dsq copied to clipboard

test.py fails on caching duration

Open dulfox opened this issue 2 years ago • 1 comments

I have installed dsq on my manjaro (arch linux like) raspberry pi 4 with this file: PKGBUILD

Everything has worked fine until the check part which runs the test.py script.

I have one failure (48 of 49 succeeded) related to this line: https://github.com/multiprocessio/dsq/blob/8552873f2d87d1d6f9ad1246fa0daac1eb5d833b/scripts/test.py#L303

cat taxi.csv | ./dsq --cache -s csv 'SELECT passenger_count, COUNT(*), AVG(total_amount) FROM {} GROUP BY passenger_count ORDER BY COUNT(*) DESC'

FAILURE: completed in 9 seconds. Wanted <5s

I have bypassed manually this test.

So, my questions are: why do you want a less than 5 seconds result ? Why is it a failure ? How can we compute the "correct time duration" related to devices (RAM size, CPU clock, thread number, etc.) ?

dulfox avatar Jun 26 '22 19:06 dulfox

Yeah this is not a great test for exactly the reasons you mention.

You can safely ignore this (and you can script ignoring this with ./scripts/test.py -nf cach).

Happy to leave this open until I have a better idea on how to test this and time to implement it.

eatonphil avatar Jun 26 '22 19:06 eatonphil