vue-cli-plugin-s3-deploy icon indicating copy to clipboard operation
vue-cli-plugin-s3-deploy copied to clipboard

New release for cacheControl option?

Open JoakimLofgren opened this issue 5 years ago • 2 comments

Hi,

I tried to use the cacheControl option to specify how long my assets should be cached, but it doesn't seem to be included in the 3.0.0 release.

E.g. I can't find these lines when I bumped to 3.0.0: https://github.com/multiplegeorges/vue-cli-plugin-s3-deploy/blob/master/s3deploy.js#L201-L203

Could you do a new release ?

JoakimLofgren avatar Mar 29 '19 14:03 JoakimLofgren

cacheControl.. isn't that handled by S3 directly?

nicekiwi avatar Apr 25 '19 05:04 nicekiwi

AFAIK you still need to set the metadata on the objects uploaded to S3.

See: https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/Expiration.html#expiration-individual-objects https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/Expiration.html#ExpirationAddingHeadersInS3

JoakimLofgren avatar Apr 25 '19 07:04 JoakimLofgren