mptcpd
mptcpd copied to clipboard
multipath-tcp
make listening socket creation optional for userspace path manager plugins
Pull Request Test Coverage Report for Build 10286346027
Details
- 6 of 8 (75.0%) changed or added relevant lines in 2 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-0.01%) to 64.766%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| lib/path_manager.c | 3 | 5 | 60.0% |
| <!-- | Total: | 6 | 8 |
| Totals | |
|---|---|
| Change from base Build 10114597542: | -0.01% |
| Covered Lines: | 1397 |
| Relevant Lines: | 2157 |
💛 - Coveralls
Modified the PR so that a new mptcpd_pm_add_addr_no_listener function is defined.
Fixed also mptcp_org_add_addr compile error for out-of-tree kernel.
Modified the PR to avoid double negation check.
do_pm_add_addr is just above mptcpd_pm_add_addr*().
It looks like the issue with the CI is due to an API breakage on ELL side. I just opened a new bug report as it is not due to these modifications, anybody can fix it: #299
@ossama-othman: if you have the opportunity, do you mind having a quick look because this PR modifies the public API please? :)
@matttbe Sure! I'll take a look today.
@marco-a-itl Thank you very much for the PR!
It looks good to me. Thank you very much!
Thank you! Just squashed and merged!
Perhaps not in this PR, but when releasing a new version of mptcpd the
NEWSfile could be updated with a description of the API addition, as well bumping the libtool versioning accordingly.
OK, noted!
From
configure.ac:# --------------------------------------------------------------- # Libtool Based Library Versioning # --------------------------------------------------------------- # Source changed: REVISION++ # Interfaces changed: CURRENT++ REVISION=0 # added: CURRENT++ REVISION=0 AGE++ # removed: CURRENT++ REVISION=0 AGE=0 LIB_CURRENT=3 LIB_REVISION=0 LIB_AGE=0
So here, because only new things have been added, I would need to update both CURRENT and AGE, to say that this lib supports everything implemented from CURRENT-AGE?