mptcpd icon indicating copy to clipboard operation
mptcpd copied to clipboard

Published 20 hours ago • verified publisher icon multipath-tcp

etc: Add Debian init.d script for mptcpd.

Open ossama-othman opened this issue 3 years ago • 7 comments

Add a Debian init.d script for mptcpd for the case where start of mptcpd through systemd is not available or undesirable.

ossama-othman avatar Jan 28 '22 01:01 ossama-othman

@matttbe FYI

ossama-othman avatar Jan 28 '22 01:01 ossama-othman

Pull Request Test Coverage Report for Build 1785594087

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.266%
Totals Coverage Status
Change from base Build 1753467561: 0.0%
Covered Lines: 1060
Relevant Lines: 1990
💛 - Coveralls

coveralls avatar Jan 28 '22 01:01 coveralls

The etc/init.d/mptcpd script generated by this change is installed even when systemd is detected by the configure script. I'm not sure that is desirable.

ossama-othman avatar Jan 28 '22 01:01 ossama-othman

I don't yet know if other platforms such as Fedora support this Debian style init.d script.

ossama-othman avatar Jan 28 '22 01:01 ossama-othman

The etc/init.d/mptcpd script generated by this change is installed even when systemd is detected by the configure script. I'm not sure that is desirable.

Yeah, that doesn't seem good - but I don't know how packagers usually handle installation of sysv-init vs systemd scripts

mjmartineau avatar Jan 28 '22 01:01 mjmartineau

The etc/init.d/mptcpd script generated by this change is installed even when systemd is detected by the configure script. I'm not sure that is desirable.

Yeah, that doesn't seem good - but I don't know how packagers usually handle installation of sysv-init vs systemd scripts

If I'm not mistaken, you can install both the init.d script and systemd service. If you use systemd and there is a service, the init.d script will be ignored I guess. e.g. for iwd: https://salsa.debian.org/debian/iwd/-/commit/65a0232b9715d9002d69d55b217ae6e3f3c75ffb

If it eases stuff, only having the file in the tarball and not installing it by default (or only with a configure option) would help packagers. If the init.d script you have is Debian-specific, we can add it in the Debian package directly and not maintain it here.

matttbe avatar Jan 28 '22 16:01 matttbe

  • (nit) the hashbang doesn't need to go through env, that's just a limitation of FreeBSD that's irrelevant here (because 1. if FreeBSD grows MPTCP support, it won't use Linux-specific internal management interfaces thus this daemon, 2. it was fixed by making /lib/init/init-d-script a binary stub)
  • description: "Debian" is merely the first distro to support, any other that uses init scripts (Slack, Alpine, ...) can use the script as-is
  • description: "init script" is redundant here
  • messing with LD_LIBRARY_PATH is indeed unneeded and harmful

kilobyte avatar Sep 09 '23 18:09 kilobyte