website icon indicating copy to clipboard operation
website copied to clipboard

Ugly title without javascript

Open hsanjuan opened this issue 7 years ago • 3 comments

It says "Star" in h1 or so because it cannot show the github button:

image

hsanjuan avatar Mar 01 '17 16:03 hsanjuan

Another NoScript user! x)

Yeah it should probably degrade more gracefully, it's totally expected that people will open the page without an internet connection

ghost avatar Mar 01 '17 16:03 ghost

It also happens with uMatix when I don't allow buttons.github.com.

Kubuxu avatar Mar 01 '17 17:03 Kubuxu

True that, should be just a static image and then upgrading if JS is present. I also spotted in the source that there is something going on with the headers: https://github.com/multiformats/website/blob/a8833dab018dbe71e516b9f578fafa2df637e14e/layouts/_default/single.html#L91-L95

We should make sure that happens on build-time as well, instead of on runtime.

victorb avatar Mar 01 '17 17:03 victorb