rust-multiaddr icon indicating copy to clipboard operation
rust-multiaddr copied to clipboard

Change Multiaddr internal structure to store parsed address

Open progval opened this issue 9 years ago • 1 comments

As of now, Multiaddr stores a byte array, representing the serialized version of the address.

Although this allows very fast serialization (array copy), I believe this is not the most appropriate format. Indeed, operations on Multiaddr (eg. decapsulate) actually work on the list of protocols, and not on the byte representation. The bug mentioned in PR #18 is a good example of it.

I see two possible representations:

  • Make Multiaddr store a Vec<Addr>, with Addr being an Enum for all supported protocols
  • Make Multiaddr only store an Addr and an Option<Multiaddr> for the inner and/or outer multiaddr.

progval avatar Sep 18 '16 09:09 progval

So my goal with how it is currently stored was to have internally the same byte representation as go-multiaddr has. If we move away from that, there needs to be at least an option to get that byte representation via a method call.

From your suggestions I think I like using Vec<Addr> the best as that matches my mental representation of a multiaddr very well. What do you think?

dignifiedquire avatar Sep 21 '16 09:09 dignifiedquire