multihash icon indicating copy to clipboard operation
multihash copied to clipboard

Published 20 hours ago • verified publisher icon multiformats

test_cases.csv is ambiguous?

Open mattnite opened this issue 5 years ago • 1 comments

Hey, just a heads up that test_cases.csv is hashing the input as a string and not as a binary. Is this intended? From my perspective, it looks like the input is intended to be base16 encoded binary.

mattnite avatar Oct 16 '19 16:10 mattnite

I agree. At this point, "known" is probably more accurate than "intended".

If you'd like to change this, go for it. If you do that, please update https://github.com/multiformats/go-multihash/blob/249ead2008065c476a2ee45e8e75e8b85d846a72/spec_test.go#L70 to match.

Stebalien avatar Nov 01 '19 18:11 Stebalien