js-cid icon indicating copy to clipboard operation
js-cid copied to clipboard

Clarify intent of type parameter in type defs

Open Gozala opened this issue 6 years ago • 1 comments

This question came up https://github.com/multiformats/js-cid/pull/79#discussion_r273321207

I should have noted what type parameter was for as it’s absolutely unclear. Creating this issue, so I can fix it by adding comments clarifing

Gozala avatar Apr 09 '19 05:04 Gozala

I have add comment elaborating on this in #82 if it get's merged this can be closed. If it's decided to not merge it, I'll add those comments here instead https://github.com/multiformats/js-cid/blob/63cd5f3dd87d8aa1549ef7b40093f07ab5e854f6/src/index.js.flow#L9

Gozala avatar Apr 16 '19 21:04 Gozala