js-cid icon indicating copy to clipboard operation
js-cid copied to clipboard

Warn when `toString` behavior will be different.

Open Gozala opened this issue 5 years ago • 2 comments

js-multiformats introduced more deterministic behavior of toString() method which could lead to a different behavior in comparison to .toString() method here.

We should amend .toString() method implementation here to print a warning in instances where behavior exhibited by js-multiformats would defer and provide a link to migration guide.

Gozala avatar Aug 07 '20 18:08 Gozala

@mikeal I've assigned it to you because I think you're only one who actually understands this.

Gozala avatar Aug 07 '20 18:08 Gozala

I think we should make sure that warning printed is actionable in some way e.g. users can opt-in into future behavior otherwise it's just going to be annoyance.

Gozala avatar Aug 07 '20 18:08 Gozala