go-multihash

go-multihash copied to clipboard

Use collision-detecting SHA1 alg

2

It's possible to detect cryptanalytic collision attacks on SHA1, there is a lib in C which implements SHA1 with this 'extension' - https://github.com/cr-marcstevens/sha1collisiondetection, we should consider using that here.

magik6k

See https://github.com/multiformats/go-multihash/blob/master/multihash.go#L219 Basically every attempt to decode creates a `DecodedMultihash` object on the heap; this has deleterious effects for things like idstore wrapping.

vyzo

Upgrade to GitHub-native Dependabot

1

_Dependabot Preview will be shut down on August 3rd, 2021. In order to keep getting Dependabot updates, please merge this PR and migrate to GitHub-native Dependabot before then._ Dependabot has...

dependabot-preview[bot]

approach to constants

6

We need to talk about how this library approaches constants. Currently: - There are a bunch of exported caps-lock constant names in the root multihash package, mapping to mulithash indicator...

warpfork

What's going on with murmur3?

4

This code looks an awful lot like it's doing a murmur3-32, and returning four bytes: https://github.com/multiformats/go-multihash/blob/6f1ea18f1da5f7735ea31b5e2011da61c409e37f/sum.go#L146-L154 And this code looks an awful lot like it's registering the above code as...

warpfork

Following readme `$ go get github.com/multiformats/go-multihash` Results `# github.com/multiformats/go-multihash go/src/github.com/multiformats/go-multihash/sum.go:136:7: undefined: sha3.NewLegacyKeccak512` `$ go version go version go1.13.8 linux/amd64` on Ubuntu 20.04 LTS

jburnett

Some algorithms don't implement Sum

2

These algorighms are found in multiformats.Names, but are never registered in sum.go. As a result, attempting to use multiformats.Sum with these algorighms raises ErrSumNotSupported. I have no need for these,...

coryschwartz

Codes for Skein?

1

Since I have discovered that Skein has 1024-bit hash, why not include it for applications that need longer for faster hashes? https://github.com/aead/skein

DonaldTsang

Inclusion of Skein

5

As a new add-on for Multihash (see https://github.com/multiformats/multihash/pull/83 and https://github.com/multiformats/multihash/issues/82) I have added some Go code to the files to comply with the new proposed standard. **I know only a...

DonaldTsang

initial pass converting to string-based multihashes

3

TODO: * [ ] Consider Nil versus Zero. * [ ] Performance (especially better decoding). * [ ] Some nice decode method for extracting information from a validated multihash. Need...

Stebalien