go-multiaddr
go-multiaddr copied to clipboard
add shs/350
Here is a pull request to add the shs protocol suite designed and first implemented in JS by @dominictarr. It is used by go-libp2p-shs.
I used protocol code 350 because it feels like it belongs below ipfs
but in top of udt
/utp
.
Great! Maybe add some tests to https://github.com/multiformats/go-multiaddr/blob/master/multiaddr_test.go to make sure it encodes/decodes as expected
How could I forget that, done.
Rest LGTM
I would be for making csv registry of transports and then assigning them and keeping parsing in packages with the transports. Which will be possible with https://github.com/multiformats/go-multiaddr/pull/42
I didn't get your plan from that one sentence but I also don't get what this has to do with this PR. I mean this was laying around for a month now (idk why it wasn't merged). I say merge it and maybe do #42 and then make this one use the new way of doing it just like all the others.
Is there a chance of this being merged? Is there something I can do to make it happen? paging @jbenet @whyrusleeping
@keks as it already conflicts with codec.go file I will pick this up and add it when #42 gets merged. Does it seems good to you?
Or when #42 is merged the parser can be part of the shs transport itself.
The protocol number should be added to protocols.csv in multiformats/multiaddr before merging.