go-multiaddr icon indicating copy to clipboard operation
go-multiaddr copied to clipboard

add shs/350

Open keks opened this issue 7 years ago • 9 comments

Here is a pull request to add the shs protocol suite designed and first implemented in JS by @dominictarr. It is used by go-libp2p-shs.

I used protocol code 350 because it feels like it belongs below ipfs but in top of udt/utp.

keks avatar Sep 16 '16 18:09 keks

Great! Maybe add some tests to https://github.com/multiformats/go-multiaddr/blob/master/multiaddr_test.go to make sure it encodes/decodes as expected

jbenet avatar Sep 16 '16 22:09 jbenet

How could I forget that, done.

keks avatar Sep 17 '16 15:09 keks

Rest LGTM

jbenet avatar Sep 17 '16 22:09 jbenet

I would be for making csv registry of transports and then assigning them and keeping parsing in packages with the transports. Which will be possible with https://github.com/multiformats/go-multiaddr/pull/42

Kubuxu avatar Oct 20 '16 18:10 Kubuxu

I didn't get your plan from that one sentence but I also don't get what this has to do with this PR. I mean this was laying around for a month now (idk why it wasn't merged). I say merge it and maybe do #42 and then make this one use the new way of doing it just like all the others.

keks avatar Oct 21 '16 10:10 keks

Is there a chance of this being merged? Is there something I can do to make it happen? paging @jbenet @whyrusleeping

keks avatar Nov 04 '16 15:11 keks

@keks as it already conflicts with codec.go file I will pick this up and add it when #42 gets merged. Does it seems good to you?

Kubuxu avatar Nov 07 '16 17:11 Kubuxu

Or when #42 is merged the parser can be part of the shs transport itself.

Kubuxu avatar Nov 07 '16 17:11 Kubuxu

The protocol number should be added to protocols.csv in multiformats/multiaddr before merging.

ghost avatar Jan 21 '17 21:01 ghost