mullvad-browser icon indicating copy to clipboard operation
mullvad-browser copied to clipboard

Mullvad-Browser dropped --class support as of recently

Open zDEFz opened this issue 2 years ago • 10 comments

Used to work: mullvad-browser -P funnyprofilename --class="funnyclassname" --class-- Does no more apply. Firefox does support it, other Firefox forks do. Whats happened here?

Running archlinux latest.

zDEFz avatar Jan 18 '24 03:01 zDEFz

What versions did this used to work in/not work in now?

morganava avatar Sep 10 '24 20:09 morganava

What versions did this used to work in/not work in now?

Current version does not work, as in 13.5.3-2 It must been a recent version from the date I opened the issue. Because I would immediately report tickets. Where can we see what was released when and how do we downgrade and test?

Natively, firefox has the ability to define class and profile. /usr/bin/firefox -P "$profilename" --name="$app_id" --class="$x11_classname" &

mullvad-browser used to support this, too. But functionality of such appears to be stripped.

If I am mistaken...

Then this may be a feature request.

zDEFz avatar Sep 11 '24 06:09 zDEFz

Are you using a flatpak/snap? Cause I think they are preventing changes to things like app_id and x11_class

sertonix avatar Sep 11 '24 13:09 sertonix

Are you using a flatpak/snap? Cause I think they are preventing changes to things like app_id and x11_class

I just use latest binary here https://aur.archlinux.org/packages/mullvad-browser-bin

zDEFz avatar Sep 11 '24 14:09 zDEFz

The easiest to browse and have date information at the same time would be to look at the Github Releases page: https://github.com/mullvad/mullvad-browser/releases

Otherwise, there's also a full archive available from: https://archive.torproject.org/tor-package-archive/mullvadbrowser/

ruihildt avatar Sep 13 '24 13:09 ruihildt

The easiest to browse and have date information at the same time would be to look at the Github Releases page: https://github.com/mullvad/mullvad-browser/releases

Otherwise, there's also a full archive available from: https://archive.torproject.org/tor-package-archive/mullvadbrowser/

I found a solution. Hear me out, this is absolutely bizarre.

  1. Run mullvad-browser -P foo
  2. Create a new profile and then delete it
  3. Select default-release and check Use the selected profile without asking at startup

Afterwards, mullvad-browser --name="profilename" --class="profilename" actually sets name and class

Maybe this is about permissions? In any case, we should provide that info somewhere, until we really know whats happening here.

zDEFz avatar Sep 25 '24 00:09 zDEFz

What info do you need? I now have the behavior again, after installing https://aur.archlinux.org/packages/mullvad-browser-latest-bin. Downgrade doesnt help. I start to think this has to do with permissions or something!

edit

It seems you really have to fully exit your Sway session and re-enter it, even after closing all Mullvad Browser instances—perhaps due to lingering or "zombie" processes. Any advice on debugging this? Maybe strace or another tool?

Could it be that it’s detecting a running process and passing a command to it?

zDEFz avatar Nov 01 '24 19:11 zDEFz

It turns out if any derivative of firefox launches in safe-mode, it will not respect the command line for the class specified. As firefox is a little special when being killed off by the compositor, it needs special treatment.


function sway_exit() {
	pkill -SIGTERM firefox
	sleep 5
	while pgrep -x "firefox" > /dev/null
	do
		sleep 1
	done
	sway exit
}

If firefox / mullvad-browser is out of that state, it will launch as needed.

zDEFz avatar Nov 10 '24 23:11 zDEFz

https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/41312 <- https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40924

cc @boklm

Thorin-Oakenpants avatar Nov 27 '24 23:11 Thorin-Oakenpants

https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/41312 <- https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/issues/40924

cc @boklm

I don't understand. Does that mean I can no more set it for every profile I have? That would be really a step backwards, I got around 30 profiles across different firefox browsers. Or can I still do mullvad-browser MOZ_APP_REMOTINGNAME=foo or firefox MOZ_APP_REMOTINGNAME=foo ???

zDEFz avatar Nov 28 '24 06:11 zDEFz