mullvad-browser icon indicating copy to clipboard operation
mullvad-browser copied to clipboard

Touch screen/gestures support?

Open Button4Button opened this issue 2 years ago • 24 comments

I know that there's various issues or workarounds to get touch screen to work with FF (export MOZ_USE_XINPUT2=1) but is there any chance that MVB could build touch support in as a default. It's very handy to have full touch support (Brave does this by default). Many thanks.

Button4Button avatar Sep 15 '23 08:09 Button4Button

Touch works for me on my windows laptop - I can scroll, pinch to zoom, tap buttons etc - and I can use a pen.

Please explain what is the actual issue. Is nothing working? What is your OS? Show the differences with your brave example. What does "full" touch support mean?

Thorin-Oakenpants avatar Sep 15 '23 14:09 Thorin-Oakenpants

Sorry, I didn't explain the issue very well.

  1. I'm on Linux (Mint and Chromebook subsystem)
  2. Brave reacts to touch events (zoom, pinch, scroll) as expected. MVB reacts to touch by highlighting page content. It will scroll down in highlight mode but continues to highlight everything on the page as it goes. Please see videos attached.

bravetouch1.webm mvbtouch1.webm

Button4Button avatar Sep 15 '23 16:09 Button4Button

OK, here's two questions

  • does it work with MB13? : which is a years worth of firefox changes, being based on ESR115 - grab from https://cdn.mullvad.net/browser/13.0a3/
  • does it work in Firefox?

Otherwise on a quick search this seems to pop up as a Linux issue (and not just in Firefox) but I haven't dived down that rabbit hole yet - let's test Firefox first: the bug being that tap starts select mode

Thorin-Oakenpants avatar Sep 15 '23 18:09 Thorin-Oakenpants

I have the same problem. Operation via a touchscreen does not work as described above.

Touch Screen / Gestures works under Firefox 121.0

My system:

OS: Arch Linux x86_64 Kernel: 6.6.9-arch1-1 DE: Plasma 5.27.10 Display Server: Wayland

olmet avatar Jan 06 '24 15:01 olmet

I can reproduce with Mullvad Browser on Arch/KDE (On a Steamdeck).

ruihildt avatar Mar 25 '24 13:03 ruihildt

Setting dom.w3c_touch_events.enabled to 1 (enabled) or 2 (auto-detect, the default in Firefox) fixes touch scrolling for me. Note: I assume this changes the browser fingerprint.

Mullvad Browser 13.0.15 Linux/NixOS, nixpkgs-unstable, Wayland

lxwntr avatar May 30 '24 12:05 lxwntr

Setting dom.w3c_touch_events.enabled to 1 (enabled) or 2 (auto-detect, the default in Firefox) fixes touch scrolling for me. Note: I assume this changes the browser fingerprint.

https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/28535

  • particularly https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/28535#note_2848069

I need to revisit and re-read everything including later comments. The idea is, I believe (i.e I believe we can code this with no compat issues), is to treat all devices as touch capable - all non-user-generated fingerprints will look alike. Just because a user doesn't use touch (because they can't or use a mouse/pad on a touch capable device) doesn't mean anything - and if they did, well it's a metric the FPing script would have to wait for, and they simply do not do this as a rule of thumb

Thorin-Oakenpants avatar May 30 '24 15:05 Thorin-Oakenpants