coding-guidelines

coding-guidelines copied to clipboard

In bash guidelines add that constants should be `readonly` always and that non-constants that are not modified after declaration should be `readonly` on a best-effort basis. Remove the part of...

Jontified

Bash - Flag constants as read-only

5

### Global constants In your coding guidelines: https://github.com/mullvad/coding-guidelines/blob/5c5931de7a7b0efde46a3fc91d3ec62ec10a58a4/bash.md?plain=1#L58-L62 May I suggest to also declare these as readonly for more strictness? The above example would become: ```bash readonly SCREAMING_SNAKE_CASE="something" ``` Your...

MrChocolatine

If a type does not include the unit of the value, the variable name has to. Otherwise it becomes hard to know what is what. ```rust // The type expresses...

faern

Module named `tests` (plural). Don't start test functions with `test_` etc. Unit tests vs integration tests.

faern