vaultPass icon indicating copy to clipboard operation
vaultPass copied to clipboard

Implement adding secrets to vault from UI

Open Kamilcuk opened this issue 2 years ago • 1 comments

Try to implement #22 .

I needed/wanted to refactor a lot to have common code paths instead of separate. The frivolous usage of global namespace and pollution of symbols will bite in the long run. I added some comments, but the code is anyway a long way from mediocre.

I added "add" page for adding passwords from the ui. The fields is filled with the first matched pattern and secrets group to ease up filling. I use only a single secrets group.

This requires testing if it works correctly for all users, if errors are properly handled. Also needs to be tested with multiple secrets directory, I use only one. Thanks.

Kamilcuk avatar Dec 04 '23 22:12 Kamilcuk

Thanks for investing effort to refactor and improve the code. If possible, please split your work into one PR that refactors and then a second PR that adds functionality. That way it's much easier for me to review

mulbc avatar Dec 05 '23 15:12 mulbc