Muir Manders

Results 62 comments of Muir Manders

> I'll disable client-side filtering for gopls as a quick fix. Thanks, that did the trick. I looked at other clients/servers and opened a bug for gopls golang/go#31552 since gopls...

This issue has been fixed in gopls for a while. We can probably close this issue (and re-enable the client side filtering, if desired).

Unless I'm misreading, Conviction and Reconnection policies only apply to errors encountered when connecting to hosts, not to query errors. (And Conviction seems to only apply to the first host...

`lsp-find-references` works normally, as I mentioned. Stack: ``` Debugger entered--Lisp error: (wrong-type-argument hash-table-p nil) gethash("uri" nil) lsp--location-to-td-position(nil) lsp--symbol-info-to-identifier(#) mapcar(lsp--symbol-info-to-identifier (# #)) #f(compiled-function (function sequence) #)(lsp--symbol-info-to-identifier (# #)) apply(#f(compiled-function (function sequence)...

This was my test Foo.java file for your reference: ``` package foo; public class Foo { private void foo() { } private void bar() { foo(); } } ```

There was no "document/references" call when I did xref-find-references. It only called "document/documentSymbol" (or it crashed before getting to the "document/references" call). Below is the "document/references" call when I run...

Ah, I see now. The problem is `xref-find-references` always prompts for the identifier, and the lsp supplied identifier list has no context, so all variables in your file named "foo"...

It is still worth noting that without my above workaround lsp-java behaves differently from other lsp-mode languages (e.g. rust). In rust, `xref-find-references` prompts for the identifier and works if you...

FYI gopls provides [completion](https://github.com/golang/tools/blob/master/internal/lsp/source/completion/package.go) for the `package` statement now in empty files.

I see, thanks. gopls does a lot of type aware candidate ordering, so ideally the client would not re-order candidates at all based purely on text matching. Previously VSCode had...