mui icon indicating copy to clipboard operation
mui copied to clipboard

Support React strict mode

Open bartvde opened this issue 6 years ago • 1 comments

Are there any plans to support strict mode for the react components? I.e. to upgrade the components so they can be safely used for the async rendering in newer react versions?

https://reactjs.org/docs/strict-mode.html

Warning: Unsafe lifecycle methods were found within a strict-mode tree:
    in Provider (at app.js:181)
    in App (at index.js:7)

componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead: Select

Learn more about this warning here:
https://fb.me/react-strict-mode-warnings

bartvde avatar May 31 '18 08:05 bartvde

Yes but it would definitely speed things up if someone volunteered to take the lead on the project. Would you be interested in working on this? I can help point you to the key places in the code.

On May 31, 2018, at 4:10 AM, Bart van den Eijnden [email protected] wrote:

Are there any plans to support strict mode for the react components? I.e. to upgrade the components so they can be safely used for the async rendering in newer react versions?

https://reactjs.org/docs/strict-mode.html

Warning: Unsafe lifecycle methods were found within a strict-mode tree: in Provider (at app.js:181) in App (at index.js:7)

componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead: Select

Learn more about this warning here: https://fb.me/react-strict-mode-warnings — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

amorey avatar May 31 '18 13:05 amorey