mui-x icon indicating copy to clipboard operation
mui-x copied to clipboard

Published 20 hours ago • verified publisher icon mui

[pickers] Draft support for js-joda

Open joshkel opened this issue 2 years ago • 8 comments

Fixes #6470 / #4703

This also includes https://github.com/dmtrKovalenko/date-io/pull/634.

If this basic approach seems desirable (if you're still interested in supporting js-joda, if you're willing to include workarounds for apparent date-io issues, etc.), then I can clean this up by adding tests and revisiting locale support.

joshkel avatar Mar 29 '23 20:03 joshkel

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-8438--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 672.2 1,142.9 719 870.14 176.597
Sort 100k rows ms 704.5 1,413.9 1,413.9 1,116.16 266.395
Select 100k rows ms 294.7 362 315.3 321.02 22.202
Deselect 100k rows ms 186.5 313.6 252.6 251.62 42.47

Generated by :no_entry_sign: dangerJS against b335fbce412e564a2f28445d50f0fe986fa3500a

mui-bot avatar Mar 29 '23 21:03 mui-bot

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Apr 07 '23 06:04 github-actions[bot]

Hi,

Thanks for your help I'm currently migrating all the adapters from @date-io to our repository in order to ease the major evolution we might want to do in the future.

Once this is done, we could probably try again to create a working JS Joda adapter.

flaviendelangle avatar Apr 27 '23 13:04 flaviendelangle

@flaviendelangle Is there an issue or PR tracking the migration of these adapters?

Our team also is using js-joda, so we would like to subscribe to get updates.

psigns avatar May 11 '23 04:05 psigns

https://github.com/mui/mui-x/issues/4703

You can track this one :+1:

flaviendelangle avatar May 11 '23 14:05 flaviendelangle

(I have added the review request to remove the PR from https://tools-public.onrender.com/prod/pages/1t353h04)

oliviertassinari avatar May 20 '23 12:05 oliviertassinari

I've updated my js-joda adapter for the current version of MUI-X.

If any users of js-joda are interested in giving it a try, I'd appreciate it. It works for my purposes (a controlled date picker using a js-joda LocalDate) and for the basic demo, but I haven't tested all of the combinations of MUI-X components and features with js-joda data types.

If the MUI-X team wants to include it, I'm happy to continue working on this PR. If not, I understand; I can see about creating a separate NPM package in that case.

joshkel avatar Apr 28 '24 01:04 joshkel

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Apr 30 '24 12:04 github-actions[bot]