mui-x icon indicating copy to clipboard operation
mui-x copied to clipboard

[DataGrid] Support scrolling over column headers under experimental flag

Open cherniavskii opened this issue 2 years ago • 7 comments

This is an experiment I suggested previously in https://github.com/mui/mui-x/issues/5416#issuecomment-1178958788 We can release it under the scrollOverColumnHeaders experimental flag if the team agrees it's a good idea. For demonstration purposes, the feature is enabled by default in this PR.

Preview: https://deploy-preview-8343--material-ui-x.netlify.app/x/react-data-grid/scrolling/

cherniavskii avatar Mar 22 '23 15:03 cherniavskii

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-8343--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 688.2 1,021.4 706.4 823.84 147.609
Sort 100k rows ms 666.4 1,191.4 1,191.4 950.82 180.105
Select 100k rows ms 223.3 412.6 312.7 330.78 67.627
Deselect 100k rows ms 156.1 287.5 206.5 211.44 43.676

Generated by :no_entry_sign: dangerJS against bdf9c256394f8279b41336d68d4aaf9878d97b96

mui-bot avatar Mar 22 '23 15:03 mui-bot

What do you think @mui/xgrid ?

cherniavskii avatar Mar 22 '23 16:03 cherniavskii

Ah, we'll need docs for it, too, of course!

joserodolfofreitas avatar Apr 27 '23 08:04 joserodolfofreitas

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar May 12 '23 14:05 github-actions[bot]

Any news on whether this is happening?

I would find it very useful as the default behaviour doesn't feel right.

a19s avatar Feb 15 '24 17:02 a19s

It's already done thanks to the #10059 feature, we may want to close this PR now.

CC @cherniavskii

MBilalShafi avatar Feb 16 '24 01:02 MBilalShafi

It's already done thanks to the #10059 feature, we may want to close this PR now.

CC @cherniavskii

Thank you very much for letting me know!

a19s avatar Feb 16 '24 13:02 a19s

Closed by https://github.com/mui/mui-x/pull/10059

cherniavskii avatar Mar 18 '24 11:03 cherniavskii