mui-x icon indicating copy to clipboard operation
mui-x copied to clipboard

[core] Bump monorepo

Open LukasTy opened this issue 2 years ago • 6 comments

Bump monorepo to apply changes from https://github.com/mui/material-ui/pull/36291 fixing adapters dependencies resolving. Waiting on the second half of changes extracted to https://github.com/mui/material-ui/pull/36310.

  • update tests fixing TS issues introduced by added type-safety
  • add @mui-internal/docs-utilities module resolution

LukasTy avatar Feb 22 '23 09:02 LukasTy

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-8006--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 753.7 1,295.2 753.7 963.56 195.775
Sort 100k rows ms 747.2 1,331.5 1,331.5 1,089 205.785
Select 100k rows ms 255.7 357.5 297.5 306.58 37.632
Deselect 100k rows ms 176.6 287.7 261.5 250.94 38.437

Generated by :no_entry_sign: dangerJS against 774526a5e0be75f8bae4d66be800f4a432683e87

mui-bot avatar Feb 22 '23 09:02 mui-bot

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Feb 22 '23 16:02 github-actions[bot]

This was a bit annoying monorepo bump due to a few breaking changes 🙈 I'd love an eye from @mui/xgrid on the Data Grid test updates/changes. 🤔

LukasTy avatar Feb 22 '23 16:02 LukasTy

:rofl: OK I could have done this bump after merging the PR that adds typing on the core Thanks for taking care of it !

flaviendelangle avatar Feb 23 '23 07:02 flaviendelangle

I've noticed that my previous workaround to have legible playgrounds when in dark mode has been reverted due to some issues. What do you guys @flaviendelangle @cherniavskii think about this latest commit I've done: https://github.com/mui/mui-x/pull/8006/commits/73d2bdd877b82c32361d313edf660db6eca37bb6?

LukasTy avatar Feb 23 '23 07:02 LukasTy

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Feb 23 '23 09:02 github-actions[bot]