mui-x icon indicating copy to clipboard operation
mui-x copied to clipboard

[pickers] Do not support unparsed date formats anymore

Open flaviendelangle opened this issue 3 years ago • 5 comments

Closes #5759

flaviendelangle avatar Sep 15 '22 17:09 flaviendelangle

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 548.7 932.9 814.7 744.14 148.378
Sort 100k rows ms 625.6 1,006.6 746 869.9 155.38
Select 100k rows ms 179.1 272.4 206.9 219.82 32.87
Deselect 100k rows ms 140.6 283.5 197.4 218.08 54.098

Generated by :no_entry_sign: dangerJS against 5b0aae22f1c42b5b6d21bdca80a89c22bae36647

mui-bot avatar Sep 15 '22 17:09 mui-bot

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Sep 16 '22 11:09 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Sep 19 '22 07:09 github-actions[bot]

I read some files, but it would take an eternity to open each file modification to check if modification are just type renaming or logic modification.

[...document.querySelectorAll('button.load-diff-button')].forEach(button => button.click());

🙈 😆

LukasTy avatar Sep 20 '22 13:09 LukasTy

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Sep 21 '22 08:09 github-actions[bot]

I read some files, but it would take an eternity to open each file modification to check if modification are just type renaming or logic modification. Are there some specific lines on which you have a doubt?

The internals mostly, the main point of risk for me is in usePickerState and the shared.ts (for each picker family)

flaviendelangle avatar Sep 22 '22 07:09 flaviendelangle

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Sep 22 '22 07:09 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Sep 23 '22 15:09 github-actions[bot]