mui-x icon indicating copy to clipboard operation
mui-x copied to clipboard

[license] Give more context in the missing license

Open oliviertassinari opened this issue 3 years ago • 2 comments

This is related to #5730. I'm trying to improve the DX from https://codesandbox.io/s/1cm3xe?file=/demo.tsx.

Before

Screenshot 2022-08-08 at 01 26 43

After

Screenshot 2022-08-08 at 01 26 31

oliviertassinari avatar Aug 07 '22 23:08 oliviertassinari

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 267.6 498.2 327.4 355.44 88.494
Sort 100k rows ms 540.1 904.6 816.2 764.44 125.527
Select 100k rows ms 193.4 259.9 215.3 216.94 23.195
Deselect 100k rows ms 131.2 367.6 190.8 209.3 82.512

Generated by :no_entry_sign: dangerJS against c5013210c5dbd296a3e43e27d279744cf172cfa3

mui-bot avatar Aug 07 '22 23:08 mui-bot

@LukasTy I think that we have room to continue these types of improvements. It's one iteration I had the time to do during the weekend. #1364 is kind of an umbrella issue for this topic.

oliviertassinari avatar Aug 08 '22 13:08 oliviertassinari

what do you think about adding similar additions to other two (invalid and expired) license status errors?

@LukasTy I have updated #1364 to better keep track of the opportunities that we have, taking your feedback into account.

oliviertassinari avatar Aug 12 '22 23:08 oliviertassinari