mui-x icon indicating copy to clipboard operation
mui-x copied to clipboard

[charts] Fix missing memoization

Open JCQuintas opened this issue 1 month ago • 1 comments

selectorChartAxisInteraction iterates over arrays selectorChartAxisZoomData can technically return different values if we update the map directly, though probably not, let me know if you think we should keep as is

JCQuintas avatar Dec 10 '25 16:12 JCQuintas

Deploy preview: https://deploy-preview-20618--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 🔺+1B(0.00%)
@mui/x-charts-pro 🔺+1B(0.00%) 🔺+2B(0.00%)
@mui/x-charts-premium 0B(0.00%) 🔺+2B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by :no_entry_sign: dangerJS against 977f9452895d77b52db31ae18b1a7219faf7f4c4

mui-bot avatar Dec 10 '25 16:12 mui-bot

CodSpeed Performance Report

Merging #20618 will not alter performance

Comparing JCQuintas:memoize-selectors (977f945) with master (63d66ca)[^unexpected-base] [^unexpected-base]: No successful run was found on master (c4c58b3) during the generation of this report, so 63d66ca was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Summary

✅ 13 untouched

codspeed-hq[bot] avatar Dec 10 '25 16:12 codspeed-hq[bot]

Does this fix any bug or have a meaningful performance impact? Just curious

bernardobelchior avatar Dec 10 '25 17:12 bernardobelchior