mui-x icon indicating copy to clipboard operation
mui-x copied to clipboard

[WIP][charts] Try some label improvement on sankey

Open alexfauquette opened this issue 1 month ago • 1 comments

alexfauquette avatar Dec 09 '25 09:12 alexfauquette

Deploy preview: https://deploy-preview-20604--material-ui-x.netlify.app/

Updated pages:

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 🔺+1.73KB(+0.38%) 🔺+208B(+0.15%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by :no_entry_sign: dangerJS against 9f98b213fad9d93637c51c182facf0a002d6d4a7

mui-bot avatar Dec 09 '25 09:12 mui-bot

CodSpeed Performance Report

Merging #20604 will not alter performance

Comparing alexfauquette:sankey-update (9f98b21) with master (139a02a)[^unexpected-base] [^unexpected-base]: No successful run was found on master (a192707) during the generation of this report, so 139a02a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Summary

✅ 13 untouched

codspeed-hq[bot] avatar Dec 12 '25 08:12 codspeed-hq[bot]

Did my best to simplify but ended up to the conclusion that we can not display all those labels on mobile

@JCQuintas About the approach to allow users for creating this same node labels. I could introduce a slot 😈 But I'm considering exporting a SankeyNodePlot, SankeyLinkPlot, SankeyNodeLablePlot, SankeyLinkLablePlot to do the demo with composition (reuse SankeyNodePlot, SankeyLinkPlot and do custom SankeyNodeLablePlot, SankeyLinkLablePlot)

alexfauquette avatar Dec 15 '25 15:12 alexfauquette

Did my best to simplify but ended up to the conclusion that we can not display all those labels on mobile

Yes, an option for mobile should be to make the sankey vertical, or provide the labels outside the context of the chart.

I didn't want to implement composition for the sankey before the headless migration, so we don't have yet another slot to move over 😆

JCQuintas avatar Dec 15 '25 16:12 JCQuintas

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Dec 17 '25 09:12 github-actions[bot]