mui-x icon indicating copy to clipboard operation
mui-x copied to clipboard

[charts] Move series default to selector

Open JCQuintas opened this issue 1 month ago • 5 comments

What do you think about moving these default setting to the selector?

This doesn't specifically bring any value, but it could technically allow us to use other selectors when defaulting

JCQuintas avatar Nov 27 '25 11:11 JCQuintas

Deploy preview: https://deploy-preview-20468--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts ▼-83B(-0.02%) ▼-12B(-0.01%)
@mui/x-charts-pro ▼-83B(-0.02%) ▼-26B(-0.02%)
@mui/x-charts-premium ▼-83B(-0.02%) ▼-2B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by :no_entry_sign: dangerJS against 5f30433605716d179e06235275cfe192d7476bae

mui-bot avatar Nov 27 '25 11:11 mui-bot

CodSpeed Performance Report

Merging #20468 will not alter performance

Comparing JCQuintas:defaultize-to-selector (5f30433) with master (8acbe5b)

Summary

✅ 13 untouched

codspeed-hq[bot] avatar Nov 27 '25 11:11 codspeed-hq[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 28 '25 10:11 github-actions[bot]

This doesn't specifically bring any value, but it could technically allow us to use other selectors when defaulting

Is there a use case for using selectors before setting the defaults?

bernardobelchior avatar Dec 02 '25 08:12 bernardobelchior

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Dec 04 '25 11:12 github-actions[bot]