mui-x icon indicating copy to clipboard operation
mui-x copied to clipboard

[charts-pro] Improve Sankey node label handling

Open JCQuintas opened this issue 2 months ago • 4 comments

Fixes https://github.com/mui/mui-x/issues/20076

JCQuintas avatar Nov 04 '25 09:11 JCQuintas

Deploy preview: https://deploy-preview-20191--material-ui-x.netlify.app/

Updated pages:

Bundle size report

Bundle size will be reported once CircleCI build #695292 finishes.

Generated by :no_entry_sign: dangerJS against a6bb93fbaddcd86aa1cc1da8fa5424b4d5501ad5

mui-bot avatar Nov 04 '25 09:11 mui-bot

CodSpeed Performance Report

Merging #20191 will degrade performances by 14.13%

Comparing JCQuintas:sankey-node-text (f8b4a73) with master (81ae8b1)[^unexpected-base] [^unexpected-base]: No successful run was found on master (3914ec5) during the generation of this report, so 81ae8b1 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Summary

❌ 3 regressions
✅ 10 untouched

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
Simulation SankeyChart with big data amount 115.1 ms 134 ms -14.13%
Simulation ScatterChartPro with big data amount and zoomed in (single renderer) 65 ms 71.5 ms -9.13%
Simulation ScatterChartPro with big data amount and zoomed in (batch renderer) 65.6 ms 72.1 ms -9.06%

codspeed-hq[bot] avatar Nov 04 '25 10:11 codspeed-hq[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 28 '25 10:11 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Dec 05 '25 12:12 github-actions[bot]