mui-x icon indicating copy to clipboard operation
mui-x copied to clipboard

Bump React

Open renovate[bot] opened this issue 7 months ago • 2 comments

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/react (source) ^19.0.10 -> ^19.1.6 age adoption passing confidence
@types/react (source) ^19.0.12 -> ^19.1.6 age adoption passing confidence
@types/react-dom (source) ^19.0.4 -> ^19.1.5 age adoption passing confidence
react (source) ^19.0.0 -> ^19.1.0 age adoption passing confidence
react-dom (source) ^19.0.0 -> ^19.1.0 age adoption passing confidence

Release Notes

facebook/react (react)

v19.1.0

Compare Source

facebook/react (react-dom)

v19.1.0

Compare Source


Configuration

📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • [ ] If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

renovate[bot] avatar Jun 01 '25 01:06 renovate[bot]

Deploy preview: https://deploy-preview-18166--material-ui-x.netlify.app/

Bundle size report

Total Size Change:${\tiny{\color{red}▲}}$+40B(0.00%) - Total Gzip Change:${\tiny{\color{red}▲}}$+48B(0.00%) Files: 120 total (0 added, 0 removed, 45 changed)

Show 45 more bundle changes

@mui/x-chartsparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%) @mui/x-charts-pro/ChartsToolbarProparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(+0.01%) @mui/x-charts-pro/ChartZoomSliderparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%) @mui/x-charts/BarChartparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(0.00%) @mui/x-charts/ChartContainerparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(+0.01%) @mui/x-charts/ChartDataProviderparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(+0.01%) @mui/x-charts/ChartsAxisparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(+0.01%) @mui/x-charts/ChartsAxisHighlightparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%) @mui/x-charts/ChartsClipPathparsed:${\tiny{\color{red}▲}}$+2B(+0.03%) gzip:${\tiny{\color{red}▲}}$+4B(+0.13%) @mui/x-charts/ChartsGridparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%) @mui/x-charts/ChartsLegendparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(+0.01%) @mui/x-charts/ChartsOverlayparsed:${\tiny{\color{red}▲}}$+2B(+0.02%) gzip:${\tiny{\color{red}▲}}$+2B(+0.06%) @mui/x-charts/ChartsReferenceLineparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%) @mui/x-charts/ChartsSurfaceparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%) @mui/x-charts/ChartsTooltipparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%) @mui/x-charts/ChartsXAxisparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(+0.01%) @mui/x-charts/ChartsYAxisparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%) @mui/x-charts/Gaugeparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(+0.01%) @mui/x-charts/LineChartparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%) @mui/x-charts/PieChartparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%) @mui/x-charts/RadarChartparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%) @mui/x-charts/ScatterChartparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(0.00%) @mui/x-charts/SparkLineChartparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%) @mui/x-tree-viewparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(+0.01%) @mui/x-tree-view-proparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%) @mui/x-tree-view-pro/RichTreeViewProparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%) @mui/x-tree-view/RichTreeViewparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(+0.01%) @mui/x-tree-view/SimpleTreeViewparsed:${\tiny{\color{red}▲}}$+2B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(+0.01%) @mui/x-tree-view/TreeItemparsed:${\tiny{\color{red}▲}}$+2B(+0.01%) gzip:${\tiny{\color{red}▲}}$+2B(+0.02%) @mui/x-tree-view/TreeItemProviderparsed:${\tiny{\color{red}▲}}$+2B(+0.03%) gzip:${\tiny{\color{red}▲}}$+2B(+0.07%) @mui/x-charts-proparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-1B(0.00%) @mui/x-charts-pro/BarChartProparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{red}▲}}$+1B(0.00%) @mui/x-charts-pro/ChartContainerProparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-3B(-0.01%) @mui/x-charts-pro/ChartDataProviderProparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-2B(0.00%) @mui/x-charts-pro/FunnelChartparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-2B(0.00%) @mui/x-charts-pro/Heatmapparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-2B(0.00%) @mui/x-charts-pro/LineChartProparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip: 0B(0.00%) @mui/x-charts-pro/PieChartProparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip: 0B(0.00%) @mui/x-charts-pro/RadarChartProparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-2B(0.00%) @mui/x-charts-pro/ScatterChartProparsed:${\tiny{\color{green}▼}}$-2B(0.00%) gzip:${\tiny{\color{green}▼}}$-3B(0.00%) @mui/x-data-gridparsed: 0B(0.00%) gzip:${\tiny{\color{green}▼}}$-1B(0.00%) @mui/x-data-grid-premiumparsed: 0B(0.00%) gzip:${\tiny{\color{red}▲}}$+2B(0.00%) @mui/x-data-grid-premium/DataGridPremiumparsed: 0B(0.00%) gzip:${\tiny{\color{red}▲}}$+3B(0.00%) @mui/x-data-grid-proparsed: 0B(0.00%) gzip:${\tiny{\color{red}▲}}$+6B(0.00%) @mui/x-data-grid-pro/DataGridProparsed: 0B(0.00%) gzip:${\tiny{\color{red}▲}}$+4B(0.00%)

Details of bundle changes

Generated by :no_entry_sign: dangerJS against 1a133ca298a37d3c2a216543b528abb80c49e9fa

mui-bot avatar Jun 01 '25 09:06 mui-bot

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jun 01 '25 10:06 github-actions[bot]

@JCQuintas I think we agreed to postpone the bump until we find the time to investigate the cause of very significant CI runtime increase. 🤔 https://github.com/mui/mui-x/pull/17216 Have you checked it?

It looks like the test_browser is now taking almost double the time, while test_unit increased runtime by ~10%. 🤔 🙈 Screenshot 2025-06-02 at 10 36 18

P.S. More recent test_unit runs are taking even longer. 🤔

LukasTy avatar Jun 02 '25 07:06 LukasTy

Last time we reverted this because of the increase in time it took to run test_browser. It seems to have increased from around 7min (run 1, run 2) to around 11min (this PR's run).

From looking at React's issues, there doesn't seem to be any issue mentioning worse performance when running tests, so maybe it's something related to our setup?

bernardobelchior avatar Jun 02 '25 07:06 bernardobelchior

Did a small test on my Macbook Pro Apple M4 Pro, 48GB RAM and I can also reproduce the difference locally:

Seconds React 19.1: pnpm test:unit:browser --coverage React 19.0: pnpm test:unit:browser --coverage React 19.1: pnpm test:unit:browser React 19.0: pnpm test:unit:browser
Run 1 91 85 62 59
Run 2 84 78 56 51
Run 3 84 78 56 52
Run 4 83 78 56 52
Avg [1] 83.67 78 56 51.67

[1] Excluding first run

The results, excluding the first run, are as follows:

  • pnpm test:unit:browser --coverage: React 19.1 is 7.3% slower on average than React 19.0
  • pnpm test:unit:browser: React 19.1 is 8.4% slower on average than React 19.0

On CI, it seems that pnpm test:unit:browser --coverage is around 57% slower when running React 19.1 vs React 19.0.

However, CI's config is slightly different. In CI, we disable file parallelism, run the test inside a single child_process and only use one thread.

bernardobelchior avatar Jun 02 '25 08:06 bernardobelchior

config is slightly different.

You can try CI=true pnpm test:unit:browser --coverage to run the same config as CI

JCQuintas avatar Jun 02 '25 10:06 JCQuintas

@JCQuintas I think we agreed to postpone the bump until we find the time to investigate the cause of very significant CI runtime increase. 🤔 #17216 Have you checked it?

TBH I completely forgot about this. 😢

It didn't have a "request for change" so I assumed it was good to go.

JCQuintas avatar Jun 02 '25 10:06 JCQuintas