[DataGrid] Fixed preProcessEditCellProps triggered for non-editable cells
β¦ssEditCellProps is fired.
- [x] I have followed (at least) the PR section of the contributing guide.
Please add one type label to categorize the purpose of this PR appropriately:
bug, regression, enhancement, new feature, release or dependencies
Deploy preview: https://deploy-preview-18076--material-ui-x.netlify.app/
Bundle size report
Total Size Change: πΊ+456B(0.00%) - Total Gzip Change: πΊ+110B(0.00%) Files: 122 total (0 added, 0 removed, 21 changed)
Show details for 100 more bundles (22 more not shown)
@mui/x-data-gridβparsed: πΊ+76B(+0.02%) gzip: πΊ+13B(+0.01%) @mui/x-data-grid-premiumβparsed: πΊ+76B(+0.01%) gzip: πΊ+20B(+0.01%) @mui/x-data-grid-premium/DataGridPremiumβparsed: πΊ+76B(+0.01%) gzip: πΊ+17B(+0.01%) @mui/x-data-grid-proβparsed: πΊ+76B(+0.02%) gzip: πΊ+24B(+0.02%) @mui/x-data-grid-pro/DataGridProβparsed: πΊ+76B(+0.02%) gzip: πΊ+34B(+0.03%) @mui/x-data-grid/DataGridβparsed: πΊ+76B(+0.02%) gzip: πΊ+21B(+0.02%) @mui/x-chartsβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts-proβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts-pro/BarChartProβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts-pro/ChartContainerProβparsed: 0B(0.00%) gzip: βΌ-1B(0.00%) @mui/x-charts-pro/ChartDataProviderProβparsed: 0B(0.00%) gzip: βΌ-1B(0.00%) @mui/x-charts-pro/ChartsToolbarProβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts-pro/ChartZoomSliderβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts-pro/FunnelChartβparsed: 0B(0.00%) gzip: πΊ+1B(0.00%) @mui/x-charts-pro/Heatmapβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts-pro/LineChartProβparsed: 0B(0.00%) gzip: βΌ-1B(0.00%) @mui/x-charts-pro/PieChartProβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts-pro/RadarChartProβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts-pro/ScatterChartProβparsed: 0B(0.00%) gzip: βΌ-1B(0.00%) @mui/x-charts/BarChartβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts/ChartContainerβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts/ChartDataProviderβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts/ChartsAxisβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts/ChartsAxisHighlightβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts/ChartsClipPathβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts/ChartsGridβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts/ChartsLabelβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts/ChartsLegendβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts/ChartsLocalizationProviderβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts/ChartsOverlayβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts/ChartsReferenceLineβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts/ChartsSurfaceβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts/ChartsTextβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts/ChartsTooltipβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts/ChartsXAxisβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts/ChartsYAxisβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts/Gaugeβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts/LineChartβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts/PieChartβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts/RadarChartβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts/ScatterChartβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts/SparkLineChartβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-charts/Toolbarβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickersβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers-proβparsed: 0B(0.00%) gzip: βΌ-1B(0.00%) @mui/x-date-pickers-pro/AdapterDateFnsβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers-pro/AdapterDateFnsJalaliβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers-pro/AdapterDayjsβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers-pro/AdapterLuxonβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers-pro/AdapterMomentβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers-pro/AdapterMomentHijriβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers-pro/AdapterMomentJalaaliβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers-pro/DateRangeCalendarβparsed: 0B(0.00%) gzip: βΌ-2B(-0.01%) @mui/x-date-pickers-pro/DateRangePickerβparsed: 0B(0.00%) gzip: βΌ-2B(0.00%) @mui/x-date-pickers-pro/DateRangePickerDayβparsed: 0B(0.00%) gzip: βΌ-1B(-0.01%) @mui/x-date-pickers-pro/DateRangePickerDay2βparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers-pro/DateTimeRangePickerβparsed: 0B(0.00%) gzip: βΌ-1B(0.00%) @mui/x-date-pickers-pro/DesktopDateRangePickerβparsed: 0B(0.00%) gzip: βΌ-4B(-0.01%) @mui/x-date-pickers-pro/DesktopDateTimeRangePickerβparsed: 0B(0.00%) gzip: βΌ-1B(0.00%) @mui/x-date-pickers-pro/DesktopTimeRangePickerβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers-pro/LocalizationProviderβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers-pro/MobileDateRangePickerβparsed: 0B(0.00%) gzip: βΌ-1B(0.00%) @mui/x-date-pickers-pro/MobileDateTimeRangePickerβparsed: 0B(0.00%) gzip: βΌ-2B(0.00%) @mui/x-date-pickers-pro/MobileTimeRangePickerβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers-pro/MultiInputDateRangeFieldβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers-pro/MultiInputDateTimeRangeFieldβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers-pro/MultiInputTimeRangeFieldβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers-pro/PickersRangeCalendarHeaderβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers-pro/SingleInputDateRangeFieldβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers-pro/SingleInputDateTimeRangeFieldβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers-pro/SingleInputTimeRangeFieldβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers-pro/StaticDateRangePickerβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers-pro/TimeRangePickerβparsed: 0B(0.00%) gzip: βΌ-1B(0.00%) @mui/x-date-pickers/AdapterDateFnsβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers/AdapterDateFnsBaseβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers/AdapterDateFnsJalaliβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers/AdapterDayjsβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers/AdapterLuxonβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers/AdapterMomentβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers/AdapterMomentHijriβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers/AdapterMomentJalaaliβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers/DateCalendarβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers/DateFieldβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers/DatePickerβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers/DateTimeFieldβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers/DateTimePickerβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers/DayCalendarSkeletonβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers/DesktopDatePickerβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers/DesktopDateTimePickerβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers/DesktopTimePickerβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers/DigitalClockβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers/LocalizationProviderβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers/MobileDatePickerβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers/MobileDateTimePickerβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers/MobileTimePickerβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers/MonthCalendarβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers/MultiSectionDigitalClockβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers/PickerDay2βparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers/PickersActionBarβparsed: 0B(0.00%) gzip: 0B(0.00%) @mui/x-date-pickers/PickersCalendarHeaderβparsed: 0B(0.00%) gzip: 0B(0.00%)
Generated by :no_entry_sign: dangerJS against af6c1f1c93b9e84e839691d2cf447321e6fffeee
Lee
??
Hello @zannager , could you please review this short pull request?
This pull request has been inactive for 30 days. Please remove the stale label or leave a comment to keep it open. Otherwise, it will be closed in 15 days.
Hello @zannager , I am following up regarding this pull request. Could you please let me know when it will be merged? Thanks!
This pull request has conflicts, please resolve those before we can evaluate the pull request.
@GaushJ
I have just merged https://github.com/mui/mui-x/pull/18405
Both PRs are fixing the same issue, but I see that you have some additional code. Can you verify if the merged changes solve the issue for you too?
If so, you can close this PR otherwise, you will have to resolve the conflicts and push the changes
thanks
This pull request has been closed due to 15 days of inactivity after being marked stale.