mui-x icon indicating copy to clipboard operation
mui-x copied to clipboard

[charts] Improve charts toolbar accessibility

Open bernardobelchior opened this issue 7 months ago • 3 comments

Part of https://github.com/mui/mui-x/issues/17557.

Improve charts toolbar accessibility by copying the Data Grid's implementation of tab navigation and ARIA attributes.

bernardobelchior avatar May 29 '25 09:05 bernardobelchior

Thanks for adding a type label to the PR! 👍

github-actions[bot] avatar May 29 '25 09:05 github-actions[bot]

Deploy preview: https://deploy-preview-18056--material-ui-x.netlify.app/

Updated pages:

Bundle size report

Total Size Change:${\tiny{\color{red}▲}}$+30.7KB(+0.25%) - Total Gzip Change:${\tiny{\color{red}▲}}$+10.3KB(+0.27%) Files: 120 total (0 added, 0 removed, 21 changed)

@mui/x-charts-pro/ChartsToolbarProparsed:${\tiny{\color{red}▲}}$+4.16KB(+7.17%) gzip:${\tiny{\color{red}▲}}$+1.42KB(+6.83%) @mui/x-charts/Toolbarparsed:${\tiny{\color{red}▲}}$+4.01KB(+128.50%) gzip:${\tiny{\color{red}▲}}$+1.49KB(+96.63%) @mui/x-charts-proparsed:${\tiny{\color{red}▲}}$+3.31KB(+1.00%) gzip:${\tiny{\color{red}▲}}$+1.01KB(+0.99%) @mui/x-charts-pro/RadarChartProparsed:${\tiny{\color{red}▲}}$+3.14KB(+1.92%) gzip:${\tiny{\color{red}▲}}$+1.03KB(+1.92%) @mui/x-charts-pro/ScatterChartProparsed:${\tiny{\color{red}▲}}$+3.14KB(+1.59%) gzip:${\tiny{\color{red}▲}}$+1.02KB(+1.57%) @mui/x-charts-pro/BarChartProparsed:${\tiny{\color{red}▲}}$+3.14KB(+1.49%) gzip:${\tiny{\color{red}▲}}$+1.05KB(+1.51%) @mui/x-charts-pro/LineChartProparsed:${\tiny{\color{red}▲}}$+3.14KB(+1.38%) gzip:${\tiny{\color{red}▲}}$+1.03KB(+1.40%) @mui/x-charts-pro/PieChartProparsed:${\tiny{\color{red}▲}}$+3.1KB(+1.64%) gzip:${\tiny{\color{red}▲}}$+1.04KB(+1.66%) @mui/x-chartsparsed:${\tiny{\color{red}▲}}$+2.97KB(+1.12%) gzip:${\tiny{\color{red}▲}}$+1.05KB(+1.29%)

Show 12 more bundle changes

@mui/x-charts/ChartDataProviderparsed:${\tiny{\color{red}▲}}$+54B(+0.05%) gzip:${\tiny{\color{red}▲}}$+7B(+0.02%) @mui/x-charts-pro/ChartContainerProparsed:${\tiny{\color{red}▲}}$+49B(+0.03%) gzip:${\tiny{\color{red}▲}}$+18B(+0.04%) @mui/x-charts-pro/ChartDataProviderProparsed:${\tiny{\color{red}▲}}$+49B(+0.04%) gzip:${\tiny{\color{red}▲}}$+10B(+0.02%) @mui/x-charts-pro/FunnelChartparsed:${\tiny{\color{red}▲}}$+49B(+0.02%) gzip:${\tiny{\color{red}▲}}$+19B(+0.03%) @mui/x-charts-pro/Heatmapparsed:${\tiny{\color{red}▲}}$+49B(+0.03%) gzip:${\tiny{\color{red}▲}}$+15B(+0.02%) @mui/x-charts/ChartContainerparsed:${\tiny{\color{red}▲}}$+49B(+0.04%) gzip:${\tiny{\color{red}▲}}$+13B(+0.03%) @mui/x-charts/SparkLineChartparsed:${\tiny{\color{red}▲}}$+49B(+0.03%) gzip:${\tiny{\color{red}▲}}$+20B(+0.04%) @mui/x-charts/BarChartparsed:${\tiny{\color{red}▲}}$+46B(+0.03%) gzip:${\tiny{\color{red}▲}}$+16B(+0.03%) @mui/x-charts/ScatterChartparsed:${\tiny{\color{red}▲}}$+46B(+0.03%) gzip:${\tiny{\color{red}▲}}$+3B(+0.01%) @mui/x-charts/LineChartparsed:${\tiny{\color{red}▲}}$+45B(+0.02%) gzip:${\tiny{\color{red}▲}}$+25B(+0.04%) @mui/x-charts/RadarChartparsed:${\tiny{\color{red}▲}}$+43B(+0.03%) gzip:${\tiny{\color{red}▲}}$+13B(+0.03%) @mui/x-charts/PieChartparsed:${\tiny{\color{red}▲}}$+41B(+0.03%) gzip:${\tiny{\color{red}▲}}$+3B(+0.01%)

Details of bundle changes

Generated by :no_entry_sign: dangerJS against 1e1872447c384e1b9fa6f1a7b84e8636df646ddb

mui-bot avatar May 29 '25 09:05 mui-bot

CodSpeed Performance Report

Merging #18056 will not alter performance

Comparing bernardobelchior:charts-toolbar-accessibility (1e18724) with master (9abcebd)

Summary

✅ 9 untouched benchmarks

codspeed-hq[bot] avatar May 29 '25 10:05 codspeed-hq[bot]