mui-x icon indicating copy to clipboard operation
mui-x copied to clipboard

[code-infra] Add test case for core charts issue

Open Janpot opened this issue 8 months ago • 6 comments

Introduce new release:test command to run tests that only work after release:build. Used it to build a reproduction case for the https://github.com/mui/material-ui/pull/45990

Janpot avatar Apr 29 '25 14:04 Janpot

Please add one type label to categorize the purpose of this PR appropriately:

bug, regression, enhancement, new feature, release or dependencies

github-actions[bot] avatar Apr 29 '25 14:04 github-actions[bot]

Deploy preview: https://deploy-preview-17612--material-ui-x.netlify.app/

Bundle size report

Total Size Change: 0B(0.00%) - Total Gzip Change: 0B(0.00%) Files: 119 total (0 added, 0 removed, 0 changed)

Details of bundle changes

Generated by :no_entry_sign: dangerJS against 437f3ed1dbe81441d613ec6883a81bf542142a6b

mui-bot avatar Apr 29 '25 14:04 mui-bot

I tried to go a bit further in the bisection.

I tried to isolate the part of the pipeline that's breaking. To do so, I've took an other props highligtedItem that fails when running pnpm -F @mui/x-test-typescript typescript too.

And I re-implemented the props Type step by step removing the stuff that are not necessary for the definition on highligtedItem whihc is defined in the useChartHighlight pluggin (typed by UseChartHighlightSignature).

It stopped breaking when I isolated the pluggin removed the ...ChartCorePluginSignatures.

MergeSignaturesProperty<
      [
        // ...ChartCorePluginSignatures,
        ...TSignatures,
      ],
      'params'
    >

With the current state, the pnpm -F @mui/x-test-typescript typescript does not break, but uncommenting // ...ChartCorePluginSignatures makes it break

alexfauquette avatar Apr 29 '25 15:04 alexfauquette

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar May 01 '25 00:05 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar May 22 '25 13:05 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar May 28 '25 09:05 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jun 09 '25 19:06 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jun 09 '25 19:06 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 25 '25 13:11 github-actions[bot]