mui-x icon indicating copy to clipboard operation
mui-x copied to clipboard

[charts][draft] Move interaction state in store

Open alexfauquette opened this issue 1 year ago • 2 comments

alexfauquette avatar Oct 28 '24 16:10 alexfauquette

Deploy preview: https://deploy-preview-15154--material-ui-x.netlify.app/

Updated pages:

Generated by :no_entry_sign: dangerJS against 57c0d263e649dadd46f82b4da3b59f0720a13b6a

mui-bot avatar Oct 28 '24 16:10 mui-bot

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Oct 30 '24 11:10 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 04 '24 10:11 github-actions[bot]

With the selectors, we can ask the tooltip to target only the index of the x-axis which drastically reduce the number of re-render

Same behavior before the modification, and after the PR

Seems like a considerable speed up, we should consider adding interaction tests to our benchmarks as well 🤔

Plan

If we agree on this strategy or a variant, The plan would be to at least remove all the exported context in alpha, such that we can move from contexts to store without breaking stuff. Only the hooks should be available

Do you have idea on how this would look like when we move further contexts into the store?

JCQuintas avatar Nov 05 '24 10:11 JCQuintas

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 15 '24 16:11 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 18 '24 12:11 github-actions[bot]